linux-kernel - Re: [PATCH] drm/tiny: fix printk format string for 32-bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87bjugzv9f.fsf@intel.com>
Date: Tue, 04 Mar 2025 17:10:52 +0200
From: Jani Nikula <jani.nikula@...el.com>
To: Aditya Garg <gargaditya08@...e.com>, Arnd Bergmann <arnd@...nel.org>
Cc: Aun-Ali Zaidi <admin@...eit.net>, Maarten Lankhorst
 <maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>,
 Thomas Zimmermann <tzimmermann@...e.de>, David Airlie <airlied@...il.com>,
 Simona Vetter <simona@...ll.ch>, Atharva Tiwari <evepolonium@...il.com>,
 Kerem Karabay <kekrby@...il.com>, Arnd Bergmann <arnd@...db.de>,
 "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Nathan
 Chancellor <nathan@...nel.org>
Subject: Re: [PATCH] drm/tiny: fix printk format string for 32-bit

On Tue, 04 Mar 2025, Aditya Garg <gargaditya08@...e.com> wrote:
> Hi
>
>> On 4 Mar 2025, at 7:57 PM, Arnd Bergmann <arnd@...nel.org> wrote:
>> 
>> From: Arnd Bergmann <arnd@...db.de>
>> 
>> A size_t must be printed with the %z modifier instead of %l:
>> 
>> In file included from include/linux/device.h:15,
>>                 from include/linux/usb.h:19,
>>                 from drivers/gpu/drm/tiny/appletbdrm.c:19:
>> drivers/gpu/drm/tiny/appletbdrm.c: In function 'appletbdrm_send_request':
>> include/drm/drm_print.h:589:54: error: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type 'size_t' {aka 'unsigned int'} [-Werror=format=]
>> drivers/gpu/drm/tiny/appletbdrm.c:170:17: note: in expansion of macro 'drm_err'
>>  170 |                 drm_err(drm, "Actual size (%d) doesn't match expected size (%lu)\n",
>>      |                 ^~~~~~~
>> drivers/gpu/drm/tiny/appletbdrm.c: In function 'appletbdrm_read_response':
>> include/drm/drm_print.h:589:54: error: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type 'size_t' {aka 'unsigned int'} [-Werror=format=]
>> drivers/gpu/drm/tiny/appletbdrm.c:211:17: note: in expansion of macro 'drm_err'
>>  211 |                 drm_err(drm, "Actual size (%d) doesn't match expected size (%lu)\n",
>>      |                 ^~~~~~~
>> 
>> Fixes: 0670c2f56e45 ("drm/tiny: add driver for Apple Touch Bars in x86 Macs")
>> Signed-off-by: Arnd Bergmann <arnd@...db.de>
>> —
>
> Its the duplicate of:
>
> https://lore.kernel.org/dri-devel/20250304-appletbdrm-fix-size_t-specifier-v1-1-94fe1d2c91f8@kernel.org/

Pushed this one to drm-misc-next.

BR,
Jani.

>
> as well as
>
> https://lore.kernel.org/dri-devel/20250304135456.429407-1-jani.nikula@intel.com/
>
>

-- 
Jani Nikula, Intel