linux-kernel - Re: [PATCH v2 1/2] dt-bindings: power: supply: Document Maxim MAX8971 charger

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPVz0n2no1EJnf4GKSJWfYA_8h8x6BRk_ducufie90YPZR-k3g@mail.gmail.com>
Date: Mon, 3 Mar 2025 10:11:21 +0200
From: Svyatoslav Ryhel <clamor95@...il.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Sebastian Reichel <sre@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, linux-pm@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: power: supply: Document Maxim MAX8971 charger

пн, 3 бер. 2025 р. о 09:54 Krzysztof Kozlowski <krzk@...nel.org> пише:
>
> On 27/02/2025 11:55, Svyatoslav Ryhel wrote:
> >>> +
>
> Please kindly trim the replies from unnecessary context. It makes it
> much easier to find new content.
>
> >>> +  maxim,usb-in-current-limit-microamp:
> >>> +    description:
> >>> +      USB Input current limit
> >>> +    minimum: 100000
> >>> +    default: 500000
> >>> +    maximum: 1500000
> >>> +
> >>> +  maxim,ac-in-current-limit-microamp:
> >>> +    description:
> >>> +      AC Input current limit
> >>> +    minimum: 100000
> >>> +    default: 500000
> >>> +    maximum: 1500000
> >>
> >> Half of these properties as well are not suitable and duplicate existing
> >> sysfs interface.
> >>
> >
> > All these properties allow configure the charger to suit the device on
> > which it is used. None of them are required but are a nice addition.
> > Why you are denying me an ability to fully utilize hardware I have and
> > tune it to the device? All those values represent hardware registers
> > which can be customized for the device, not for the end user to mess
> > with.
>
> Because you put user-space choice or OS policy into the DT and DT is not
> for that.
>

Those are NOT user-space choice or OS policy those are vendor
configuration for a specific device and are NOT and NEVER were exposed
to user configurations EVER. User messing with those may lead to
device breaking.

> >
> >> And for remaining, still no battery.
> >>
> >
> > reference to power-supply IS included, hence the battery option is
> > there as well.
>
> I don't see it being used at all and you explicitly duplicated
> properties which means that reference is redundant and should be dropped
> with such binding. So how did you solve my request to add reference
> which then you make redundant? Add reference and use it.
>

Which properties I have duplicated?

> Best regards,
> Krzysztof