linux-kernel - Re: [PATCH v2 5/6] perf test: Add timeout to datasym workload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250304151604.GB13418@e132581.arm.com>
Date: Tue, 4 Mar 2025 15:16:04 +0000
From: Leo Yan <leo.yan@....com>
To: Namhyung Kim <namhyung@...nel.org>
Cc: Arnaldo Carvalho de Melo <acme@...nel.org>,
	Ian Rogers <irogers@...gle.com>,
	Kan Liang <kan.liang@...ux.intel.com>, Jiri Olsa <jolsa@...nel.org>,
	Adrian Hunter <adrian.hunter@...el.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...nel.org>, LKML <linux-kernel@...r.kernel.org>,
	linux-perf-users@...r.kernel.org,
	Thomas Richter <tmricht@...ux.ibm.com>
Subject: Re: [PATCH v2 5/6] perf test: Add timeout to datasym workload

On Mon, Mar 03, 2025 at 06:28:36PM -0800, Namhyung Kim wrote:
> Unlike others it has an infinite loop that make it annoying to call.
> Make it finish after 1 second and handle command-line argument to change
> the setting.
> 
> Cc: Thomas Richter <tmricht@...ux.ibm.com>
> Cc: Leo Yan <leo.yan@....com>
> Signed-off-by: Namhyung Kim <namhyung@...nel.org>

Reviewed-by: Leo Yan <leo.yan@....com>

> ---
>  tools/perf/tests/workloads/datasym.c | 23 +++++++++++++++++++++--
>  1 file changed, 21 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/perf/tests/workloads/datasym.c b/tools/perf/tests/workloads/datasym.c
> index 8e08fc75a973e5f7..8ddb2aa6a049e343 100644
> --- a/tools/perf/tests/workloads/datasym.c
> +++ b/tools/perf/tests/workloads/datasym.c
> @@ -1,3 +1,6 @@
> +#include <stdlib.h>
> +#include <signal.h>
> +#include <unistd.h>
>  #include <linux/compiler.h>
>  #include "../tests.h"
>  
> @@ -12,9 +15,25 @@ static buf buf1 = {
>  	.reserved[0] = 1,
>  };
>  
> -static int datasym(int argc __maybe_unused, const char **argv __maybe_unused)
> +static volatile sig_atomic_t done;
> +
> +static void sighandler(int sig __maybe_unused)
> +{
> +	done = 1;
> +}
> +
> +static int datasym(int argc, const char **argv)
>  {
> -	for (;;) {
> +	int sec = 1;
> +
> +	if (argc > 0)
> +		sec = atoi(argv[0]);
> +
> +	signal(SIGINT, sighandler);
> +	signal(SIGALRM, sighandler);
> +	alarm(sec);
> +
> +	while (!done) {
>  		buf1.data1++;
>  		if (buf1.data1 == 123) {
>  			/*
> -- 
> 2.48.1.711.g2feabab25a-goog
>