linux-kernel - RE: [PATCH 06/15] gpio: adp5585: use new line value setter callbacks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <PH0PR03MB6512A48F698CE67687A274EA8EC92@PH0PR03MB6512.namprd03.prod.outlook.com>
Date: Mon, 3 Mar 2025 13:46:51 +0000
From: "Hennerich, Michael" <Michael.Hennerich@...log.com>
To: Bartosz Golaszewski <brgl@...ev.pl>,
        Linus Walleij
	<linus.walleij@...aro.org>,
        Laurent Pinchart
	<laurent.pinchart@...asonboard.com>,
        Mun Yew Tham <mun.yew.tham@...el.com>, Joel Stanley <joel@....id.au>,
        Andrew Jeffery <andrew@...econstruct.com.au>
CC: "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-pwm@...r.kernel.org" <linux-pwm@...r.kernel.org>,
        "patches@...nsource.cirrus.com" <patches@...nsource.cirrus.com>,
        "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>,
        "linux-aspeed@...ts.ozlabs.org"
	<linux-aspeed@...ts.ozlabs.org>,
        Bartosz Golaszewski
	<bartosz.golaszewski@...aro.org>
Subject: RE: [PATCH 06/15] gpio: adp5585: use new line value setter callbacks



> -----Original Message-----
> From: Bartosz Golaszewski <brgl@...ev.pl>
> Sent: Monday, March 3, 2025 2:19 PM
> To: Linus Walleij <linus.walleij@...aro.org>; Bartosz Golaszewski
> <brgl@...ev.pl>; Hennerich, Michael <Michael.Hennerich@...log.com>;
> Laurent Pinchart <laurent.pinchart@...asonboard.com>; Mun Yew Tham
> <mun.yew.tham@...el.com>; Joel Stanley <joel@....id.au>; Andrew Jeffery
> <andrew@...econstruct.com.au>
> Cc: linux-gpio@...r.kernel.org; linux-kernel@...r.kernel.org; linux-
> pwm@...r.kernel.org; patches@...nsource.cirrus.com; linux-arm-
> kernel@...ts.infradead.org; linux-aspeed@...ts.ozlabs.org; Bartosz Golaszewski
> <bartosz.golaszewski@...aro.org>
> Subject: [PATCH 06/15] gpio: adp5585: use new line value setter callbacks
> 
> From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> 
> struct gpio_chip now has callbacks for setting line values that return an
> integer, allowing to indicate failures. Convert the driver to using them.
> 
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>

Acked-by: Michael Hennerich <michael.hennerich@...log.com>

> ---
>  drivers/gpio/gpio-adp5585.c | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpio/gpio-adp5585.c b/drivers/gpio/gpio-adp5585.c index
> 000d31f09671..d5c0f1b267c8 100644
> --- a/drivers/gpio/gpio-adp5585.c
> +++ b/drivers/gpio/gpio-adp5585.c
> @@ -86,14 +86,16 @@ static int adp5585_gpio_get_value(struct gpio_chip
> *chip, unsigned int off)
>  	return !!(val & bit);
>  }
> 
> -static void adp5585_gpio_set_value(struct gpio_chip *chip, unsigned int off,
> int val)
> +static int adp5585_gpio_set_value(struct gpio_chip *chip, unsigned int off,
> +				  int val)
>  {
>  	struct adp5585_gpio_dev *adp5585_gpio = gpiochip_get_data(chip);
>  	unsigned int bank = ADP5585_BANK(off);
>  	unsigned int bit = ADP5585_BIT(off);
> 
> -	regmap_update_bits(adp5585_gpio->regmap,
> ADP5585_GPO_DATA_OUT_A + bank,
> -			   bit, val ? bit : 0);
> +	return regmap_update_bits(adp5585_gpio->regmap,
> +				  ADP5585_GPO_DATA_OUT_A + bank,
> +				  bit, val ? bit : 0);
>  }
> 
>  static int adp5585_gpio_set_bias(struct adp5585_gpio_dev *adp5585_gpio,
> @@ -192,7 +194,7 @@ static int adp5585_gpio_probe(struct platform_device
> *pdev)
>  	gc->direction_input = adp5585_gpio_direction_input;
>  	gc->direction_output = adp5585_gpio_direction_output;
>  	gc->get = adp5585_gpio_get_value;
> -	gc->set = adp5585_gpio_set_value;
> +	gc->set_rv = adp5585_gpio_set_value;
>  	gc->set_config = adp5585_gpio_set_config;
>  	gc->can_sleep = true;
> 
> 
> --
> 2.45.2