linux-kernel - Re: [PATCH v2 4/6] sysctl: Fixes scsi_logging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yq134ftv8h4.fsf@ca-mkp.ca.oracle.com>
Date: Mon, 03 Mar 2025 21:24:43 -0500
From: "Martin K. Petersen" <martin.petersen@...cle.com>
To: Joel Granados <joel.granados@...nel.org>
Cc: Nicolas Bouchinet <nicolas.bouchinet@...p-os.org>,
        "Martin K. Petersen"
 <martin.petersen@...cle.com>,
        linux-kernel@...r.kernel.org, linux-rdma@...r.kernel.org,
        linux-scsi@...r.kernel.org, codalist@...a.cs.cmu.edu,
        linux-nfs@...r.kernel.org,
        Nicolas Bouchinet
 <nicolas.bouchinet@....gouv.fr>,
        Joel Granados <j.granados@...sung.com>,
        Clemens Ladisch <clemens@...isch.de>, Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jason Gunthorpe
 <jgg@...pe.ca>, Leon Romanovsky <leon@...nel.org>,
        "James E.J.
 Bottomley" <James.Bottomley@...senpartnership.com>,
        Jan Harkes
 <jaharkes@...cmu.edu>,
        Chuck Lever <chuck.lever@...cle.com>,
        Jeff Layton
 <jlayton@...nel.org>, Neil Brown <neilb@...e.de>,
        Olga Kornievskaia
 <okorniev@...hat.com>, Dai Ngo <Dai.Ngo@...cle.com>,
        Tom Talpey
 <tom@...pey.com>, Trond Myklebust <trondmy@...nel.org>,
        Anna Schumaker
 <anna@...nel.org>,
        Bart Van Assche <bvanassche@....org>,
        Zhu Yanjun
 <yanjun.zhu@...ux.dev>, Al Viro <viro@...iv.linux.org.uk>,
        Christian
 Brauner <brauner@...nel.org>
Subject: Re: [PATCH v2 4/6] sysctl: Fixes scsi_logging_level bounds


Joel,

> 1. Having the upper bound be SYSCTL_INT_MAX is not necessary (as it is
>    silently capped by proc_dointvec_minmax, but it is good to have as it
>    adds to the understanding on what the range of the values are.
>
> 2. Having the lower bound capped by SYSCTL_ZERO is needed as it will
>    prevent ppl trying to assigning negative values to the unsigned integer
>
> Let me know if you take this through the scsi subsystem so I know to
> drop it from sysctl 

Applied to 6.15/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering