linux-kernel - Re: [PATCH 6.1 1/2] erofs: handle overlapped pclusters out of crafted images properly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <whxlizkpoqifmcvjbxt35bnj5jpc5cx6wzy3nq47zteu5pefq3@umdsbzhl3wqm>
Date: Mon, 3 Mar 2025 12:19:47 +0300
From: Fedor Pchelkin <pchelkin@...ras.ru>
To: Gao Xiang <hsiangkao@...ux.alibaba.com>
Cc: Alexey Panov <apanov@...ralinux.ru>, stable@...r.kernel.org, 
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Max Kellermann <max.kellermann@...os.com>, 
	lvc-project@...uxtesting.org, syzbot+de04e06b28cfecf2281c@...kaller.appspotmail.com, 
	syzbot+c8c8238b394be4a1087d@...kaller.appspotmail.com, Chao Yu <chao@...nel.org>, linux-kernel@...r.kernel.org, 
	Yue Hu <huyue2@...lpad.com>, syzbot+4fc98ed414ae63d1ada2@...kaller.appspotmail.com, 
	Jeffle Xu <jefflexu@...ux.alibaba.com>, Gao Xiang <xiang@...nel.org>, linux-erofs@...ts.ozlabs.org
Subject: Re: [PATCH 6.1 1/2] erofs: handle overlapped pclusters out of
 crafted images properly

On Mon, 03. Mar 08:31, Gao Xiang wrote:
> On 2025/3/3 02:13, Fedor Pchelkin wrote:
> > My concern was that in 6.1 and 6.6 there is still a pattern at that
> > place, not directly related to 2080ca1ed3e4 ("erofs: tidy up
> > `struct z_erofs_bvec`"):
> > 
> > 1. checking ->private against Z_EROFS_PREALLOCATED_PAGE
> > 2. zeroing out ->private if the previous check holds true
> > 
> > // 6.1/6.6 fragment
> > 
> > 	if (page->private == Z_EROFS_PREALLOCATED_PAGE) {
> > 		WRITE_ONCE(pcl->compressed_bvecs[nr].page, page);
> > 		set_page_private(page, 0);
> > 		tocache = true;
> > 		goto out_tocache;
> > 	}
> > 
> > while the upstream patch changed the situation. If it's okay then no
> > remarks from me. Sorry for the noise..
> 
> Yeah, yet as I mentioned `set_page_private(page, 0);`
> seems redundant from the codebase, I'm fine with either
> way.

Somehow I've written that mail without seeing your last reply there first.
Now everything is clear.

I'll kindly ask Alexey to send the v2 with minor adjustments to
generally non-minor merge conflict resolutions and the backporter's
comment though.

And again, thanks for clarifying all this.