linux-kernel - Re: [PATCH next] scsi: mpt3sas: Fix buffer overflow in mpt3sas_send_mctp_passthru

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yq1r03dtto6.fsf@ca-mkp.ca.oracle.com>
Date: Mon, 03 Mar 2025 21:29:35 -0500
From: "Martin K. Petersen" <martin.petersen@...cle.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Shivasharan S <shivasharan.srikanteshwara@...adcom.com>,
        Sathya Prakash
 <sathya.prakash@...adcom.com>,
        Sreekanth Reddy
 <sreekanth.reddy@...adcom.com>,
        Suganath Prabu Subramani
 <suganath-prabu.subramani@...adcom.com>,
        "James E.J. Bottomley"
 <James.Bottomley@...senpartnership.com>,
        "Martin K. Petersen"
 <martin.petersen@...cle.com>,
        MPT-FusionLinux.pdl@...adcom.com, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH next] scsi: mpt3sas: Fix buffer overflow in
 mpt3sas_send_mctp_passthru_req()


Dan,

> The "sz" argument in mpt3sas_check_cmd_timeout() is the number of u32,
> not the number of bytes.  We dump that many u32 values to dmesg.  Passing
> the number of bytes will lead to a read overflow.  Divide by 4 to get the
> correct value.

Applied to 6.15/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering