linux-kernel - Re: [PATCH] cxl/Documentation: Remove 'mixed' from sysfs mode doc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <67c722ea4f375_1de84629460@iweiny-mobl.notmuch>
Date: Tue, 4 Mar 2025 09:57:30 -0600
From: Ira Weiny <ira.weiny@...el.com>
To: Jonathan Cameron <Jonathan.Cameron@...wei.com>, Ira Weiny
	<ira.weiny@...el.com>
CC: Dave Jiang <dave.jiang@...el.com>, Alejandro Lucero <alucerop@....com>,
	Fan Ni <fan.ni@...sung.com>, Dan Williams <dan.j.williams@...el.com>,
	<linux-kernel@...r.kernel.org>, <linux-cxl@...r.kernel.org>
Subject: Re: [PATCH] cxl/Documentation: Remove 'mixed' from sysfs mode doc

Jonathan Cameron wrote:
> On Mon, 24 Feb 2025 12:29:29 -0600
> Ira Weiny <ira.weiny@...el.com> wrote:
> 
> > Commit 188e9529a606 ("cxl: Remove the CXL_DECODER_MIXED mistake")
> > removed the mixed mode.
> > 
> > Remove it from the sysfs documentation.
> > 
> > Fixes: 188e9529a606 ("cxl: Remove the CXL_DECODER_MIXED mistake")
> > Cc: Dan Williams <dan.j.williams@...el.com>
> > Signed-off-by: Ira Weiny <ira.weiny@...el.com>
> Would be nice to put wrap back in text we aren't changing
> as creates unnecessary churn / staring at text to see if
> it is different...

100% agree that the review-ability suffers.  But keeping the text
formatted in the file makes it easier to read.  In this case that might
not be as true but I'm just kind of particular when I format paragraphs...
:-/

I hope Dave will just take it.

Thanks,
Ira

> 
> Either way
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>
> 
> > ---
> >  Documentation/ABI/testing/sysfs-bus-cxl | 15 +++++++--------
> >  1 file changed, 7 insertions(+), 8 deletions(-)
> > 
> > diff --git a/Documentation/ABI/testing/sysfs-bus-cxl b/Documentation/ABI/testing/sysfs-bus-cxl
> > index 3f5627a1210a16aca7c18d17131a56491048a0c2..3ba551ed10e29f33b9eb873bab9b542c8afb66f0 100644
> > --- a/Documentation/ABI/testing/sysfs-bus-cxl
> > +++ b/Documentation/ABI/testing/sysfs-bus-cxl
> > @@ -321,14 +321,13 @@ KernelVersion:	v6.0
> >  Contact:	linux-cxl@...r.kernel.org
> >  Description:
> >  		(RW) When a CXL decoder is of devtype "cxl_decoder_endpoint" it
> > -		translates from a host physical address range, to a device local
> > -		address range. Device-local address ranges are further split
> > -		into a 'ram' (volatile memory) range and 'pmem' (persistent
> > -		memory) range. The 'mode' attribute emits one of 'ram', 'pmem',
> > -		'mixed', or 'none'. The 'mixed' indication is for error cases
> > -		when a decoder straddles the volatile/persistent partition
> > -		boundary, and 'none' indicates the decoder is not actively
> > -		decoding, or no DPA allocation policy has been set.
> > +		translates from a host physical address range, to a device
> 
> Ideally avoid the extra diff from wrap changes in text that isn't changing.
> 
> 
> > +		local address range. Device-local address ranges are further
> > +		split into a 'ram' (volatile memory) range and 'pmem'
> > +		(persistent memory) range. The 'mode' attribute emits one of
> 
> I think actual changes only happen here.
> 
> > +		'ram', 'pmem', or 'none'. The 'none' indicates the decoder is
> > +		not actively decoding, or no DPA allocation policy has been
> > +		set.
> >  
> >  		'mode' can be written, when the decoder is in the 'disabled'
> >  		state, with either 'ram' or 'pmem' to set the boundaries for the
> > 
> > ---
> > base-commit: 8760c1c0bf7eee63a56b5f9edb42d93737a6a378
> > change-id: 20250224-remove-mixed-sysfs-e3baa7616bcc
> > 
> > Best regards,
>