linux-kernel - Re: [PATCH v4 0/5] Add support for the TPM FF-A start method

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3b9141a372e9e787089a28beeb4bf11d5a144553.camel@kernel.org>
Date: Tue, 04 Mar 2025 18:02:40 +0200
From: Jarkko Sakkinen <jarkko@...nel.org>
To: Jason Gunthorpe <jgg@...pe.ca>
Cc: Stuart Yoder <stuart.yoder@....com>, linux-integrity@...r.kernel.org, 
	peterhuewe@....de, sudeep.holla@....com, rafael@...nel.org,
 lenb@...nel.org, 	linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 0/5] Add support for the TPM FF-A start method

On Mon, 2025-03-03 at 12:55 -0400, Jason Gunthorpe wrote:
> On Sun, Mar 02, 2025 at 09:33:59PM +0200, Jarkko Sakkinen wrote:
> > WARNING: line length of 102 exceeds 100 columns
> > #764: FILE: drivers/char/tpm/tpm_crb.c:821:
> > +                              FW_BUG "TPM2 ACPI table has wrong
> > size %u for start method type %d\n",
> 
> Just ignore that, it is an error in checkpatch. Strings are required
> to
> be long. I suspect FW_BUG confused it.

Yep, as its own issue I think you are right.

I also noticed couple of additional style issues not picked
by checkpatch:

	if (rc == -ENOENT) {  // FF-A driver is not available yet
		rc = -EPROBE_DEFER;
	}

I.e. extra curly braces and "//" comment.

Should be:

	/* If driver is not available yet, request probe retry: */
	if (rc == -ENOENT)
		rc = -EPROBE_DEFER;

> 
> Jason
> 

BR, Jarkko