linux-kernel - Re: [PATCH] snd: hda: realtek: fix incorrect IS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87ikooail0.wl-tiwai@suse.de>
Date: Tue, 04 Mar 2025 17:03:55 +0100
From: Takashi Iwai <tiwai@...e.de>
To: "Arnd Bergmann" <arnd@...db.de>
Cc: "Takashi Iwai" <tiwai@...e.de>,
	"Arnd Bergmann" <arnd@...nel.org>,
	"Jaroslav Kysela" <perex@...ex.cz>,
	"Takashi Iwai" <tiwai@...e.com>,
	"Kailang Yang" <kailang@...ltek.com>,
	"Simon Trimmer" <simont@...nsource.cirrus.com>,
	"Joshua Grisham" <josh@...huagrisham.com>,
	linux-sound@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] snd: hda: realtek: fix incorrect IS_REACHABLE() usage

On Tue, 04 Mar 2025 15:54:33 +0100,
Arnd Bergmann wrote:
> 
> On Tue, Mar 4, 2025, at 15:43, Takashi Iwai wrote:
> > On Tue, 04 Mar 2025 15:25:55 +0100,
> >
> > Thanks for the patch.  Indeed it's a very corner case, but I still
> > hesitate to add a kconfig dependency.  Can we take an alternative fix
> > to define the proper dummy functions like below instead?
> 
> I'm sure that works, and I had considered something like that,
> but I really dislike the IS_REACHABLE() use because I think it
> causes more problems than it solves. (I introduced the macro
> originally but regret that).
> 
> Note that the only way to disable input is to have manually flip
> CONFIG_EXPERT and CONFIG_TTY as well as the major GPU drivers
> that select it:
> 
> config INPUT
>         tristate "Generic input layer (needed for keyboard, mouse, ...)" if EXPERT
>         default y
> 
> so in the end, there is very little difference between
> your patch and mine, as they both fix build testing on
> randconfig.

OK, I don't mind much, so I take your patch now, as this actually
reduces the code size.


thanks,

Takashi