linux-kernel - Re: [PATCH] media: gspca: Add error logging for sq905c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <248a3e62-bc34-4be0-b121-e74f1fb11b9c@xs4all.nl>
Date: Tue, 4 Mar 2025 16:54:48 +0100
From: Hans Verkuil <hverkuil@...all.nl>
To: Wentao Liang <vulab@...as.ac.cn>, mchehab@...nel.org
Cc: linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: gspca: Add error logging for sq905c_command() to
 prevent silent failure

Hi Wentao Liang,

On 03/03/2025 16:23, Wentao Liang wrote:
> Add error handling for sq905c_command() failure in sq905c_dostream().
> Log debug message with gspca_dbg() to prevent silent failure.
> 
> Signed-off-by: Wentao Liang <vulab@...as.ac.cn>
> ---
>  drivers/media/usb/gspca/sq905c.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/media/usb/gspca/sq905c.c b/drivers/media/usb/gspca/sq905c.c
> index 6ca947aef298..7bb6b24c3ed1 100644
> --- a/drivers/media/usb/gspca/sq905c.c
> +++ b/drivers/media/usb/gspca/sq905c.c
> @@ -183,7 +183,9 @@ static void sq905c_dostream(struct work_struct *work)
>  quit_stream:
>  	if (gspca_dev->present) {
>  		mutex_lock(&gspca_dev->usb_lock);
> -		sq905c_command(gspca_dev, SQ905C_CLEAR, 0);
> +		ret = sq905c_command(gspca_dev, SQ905C_CLEAR, 0);
> +		if (ret)
> +			gspca_dbg(gspca_dev, D_STREAM, "Clear command failed\n");

Thank you for this patch, but I'm not taking it, it just adds a debug message
for no good reason that I can see. It's a really old driver as well.

If you really want it, then post the patch again and explain why you want this in.

Regards,

	Hans

>  		mutex_unlock(&gspca_dev->usb_lock);
>  	}
>  	kfree(buffer);