linux-kernel - Re: [PATCH v2] regmap: debugfs: Fix name collision without atomic operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1fb8c10b-6f80-4acd-8f32-f67d94583c5f@sirena.org.uk>
Date: Tue, 4 Mar 2025 16:24:50 +0000
From: Mark Brown <broonie@...nel.org>
To: Greg KH <gregkh@...uxfoundation.org>
Cc: Zxyan Zhu <zxyan20@....com>, rafael@...nel.org, dakr@...nel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] regmap: debugfs: Fix name collision without atomic
 operations

On Tue, Mar 04, 2025 at 05:23:02PM +0100, Greg KH wrote:
> On Tue, Mar 04, 2025 at 10:24:52PM +0800, Zxyan Zhu wrote:

> >  		name = map->debugfs_name;
> > -		dummy_index++;

> Shouldn't you just use an idr here if there is a race condition?
> There's a lock built into it that should solve all of these issues.

Yes, that's probably the easiest thing.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)