linux-kernel - Re: [PATCH 0/3] Add support for hidden choices to platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bda43bf4-1d45-d1bf-8d5c-f27727ebc80e@linux.intel.com>
Date: Tue, 4 Mar 2025 18:22:36 +0200 (EET)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Mario Limonciello <superm1@...nel.org>
cc: Shyam Sundar S K <Shyam-sundar.S-k@....com>, 
    "Rafael J . Wysocki" <rafael@...nel.org>, 
    Hans de Goede <hdegoede@...hat.com>, "Luke D . Jones" <luke@...nes.dev>, 
    Mark Pearson <mpearson-lenovo@...ebb.ca>, 
    "open list:AMD PMF DRIVER" <platform-driver-x86@...r.kernel.org>, 
    open list <linux-kernel@...r.kernel.org>, 
    "open list:ACPI" <linux-acpi@...r.kernel.org>, 
    "Derek J . Clark" <derekjohn.clark@...il.com>, 
    Antheas Kapenekakis <lkml@...heas.dev>, me@...egospodneti.ch, 
    Denis Benato <benato.denis96@...il.com>, 
    Mario Limonciello <mario.limonciello@....com>
Subject: Re: [PATCH 0/3] Add support for hidden choices to platform_profile

On Fri, 28 Feb 2025, Mario Limonciello wrote:

> From: Mario Limonciello <mario.limonciello@....com>
> 
> When two drivers provide platform profile handlers but use different
> strings to mean (essentially) the same thing the legacy interface won't
> export them because it only shows profiles common to multiple drivers.
> 
> This causes an unexpected behavior to people who have upgraded from an
> earlier kernel because if multiple drivers have bound platform profile
> handlers they might not be able to access profiles they were expecting.
> 
> Introduce a concept of a "hidden choice" that drivers can register and
> the platform profile handler code will utilize when using the legacy
> interface.
> 
> There have been some other attempts at solving this issue in other ways.
> This serves as an alternative to those attempts.
> 
> Link: https://lore.kernel.org/platform-driver-x86/e64b771e-3255-42ad-9257-5b8fc6c24ac9@gmx.de/T/#t
> Link: https://lore.kernel.org/platform-driver-x86/CAGwozwF-WVEgiAbWbRCiUaXf=BVa3KqmMJfs06trdMQHpTGmjQ@mail.gmail.com/T/#m2f3929e2d4f73cc0eedd14738170dad45232fd18
> Cc: Antheas Kapenekakis <lkml@...heas.dev>
> Cc: "Luke D. Jones" <luke@...nes.dev>
> 
> Mario Limonciello (3):
>   ACPI: platform_profile: Add support for hidden choices
>   platform/x86/amd: pmf: Add 'quiet' to hidden choices
>   platform/x86/amd: pmf: Add balanced-performance to hidden choices
> 
>  drivers/acpi/platform_profile.c    | 94 +++++++++++++++++++++++-------
>  drivers/platform/x86/amd/pmf/sps.c | 11 ++++
>  include/linux/platform_profile.h   |  3 +
>  3 files changed, 87 insertions(+), 21 deletions(-)
> 
> 

Acked-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>

-- 
 i.