linux-kernel - Re: [PATCH] wifi: iwlegacy: avoid size increase

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250304161839.GA67578@wp.pl>
Date: Tue, 4 Mar 2025 17:18:39 +0100
From: Stanislaw Gruszka <stf_xl@...pl>
To: Arnd Bergmann <arnd@...nel.org>
Cc: Johannes Berg <johannes@...solutions.net>,
	Arnd Bergmann <arnd@...db.de>, linux-wireless@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] wifi: iwlegacy: avoid size increase

On Tue, Mar 04, 2025 at 03:42:07PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> My previous patch caused a slight code size increase when DEBUG_FS is disabled,
> as Stanislaw Gruszka pointed out.
> 
> Fix this with an added IS_ENABLED() check.
> 
> Fixes: cf6b9ba172dd ("wifi: iwlegacy: don't warn for unused variables with DEBUG_FS=n")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
> Ideally this would be folded into my original fix. If that's not possible,
> please apply on top.

Acked-by: Stanislaw Gruszka <stf_xl@...pl>

>  drivers/net/wireless/intel/iwlegacy/4965-rs.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/net/wireless/intel/iwlegacy/4965-rs.c b/drivers/net/wireless/intel/iwlegacy/4965-rs.c
> index f754fb979546..0e5130d1fccd 100644
> --- a/drivers/net/wireless/intel/iwlegacy/4965-rs.c
> +++ b/drivers/net/wireless/intel/iwlegacy/4965-rs.c
> @@ -2495,6 +2495,9 @@ il4965_rs_dbgfs_set_mcs(struct il_lq_sta *lq_sta, u32 * rate_n_flags, int idx)
>  	u8 valid_tx_ant;
>  	u8 ant_sel_tx;
>  
> +	if (!IS_ENABLED(CONFIG_MAC80211_DEBUGFS))
> +		return;
> +
>  	il = lq_sta->drv;
>  	valid_tx_ant = il->hw_params.valid_tx_ant;
>  	if (lq_sta->dbg_fixed_rate) {
> -- 
> 2.39.5
>