linux-kernel - Re: [PATCH 2/3] net: ipa: Fix QSB data for v4.7

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5b2c08d1-47fc-43f2-abcb-f5f54fad84e1@riscstar.com>
Date: Tue, 4 Mar 2025 10:50:10 -0600
From: Alex Elder <elder@...cstar.com>
To: Luca Weiss <luca.weiss@...rphone.com>, Alex Elder <elder@...nel.org>,
 Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Cc: ~postmarketos/upstreaming@...ts.sr.ht, phone-devel@...r.kernel.org,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] net: ipa: Fix QSB data for v4.7

On 2/27/25 4:33 AM, Luca Weiss wrote:
> As per downstream reference, max_writes should be 12 and max_reads
> should be 13.
> 
> Fixes: b310de784bac ("net: ipa: add IPA v4.7 support")
> Signed-off-by: Luca Weiss <luca.weiss@...rphone.com>

Looks good.

Reviewed-by: Alex Elder <elder@...cstar.com>

> ---
>   drivers/net/ipa/data/ipa_data-v4.7.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ipa/data/ipa_data-v4.7.c b/drivers/net/ipa/data/ipa_data-v4.7.c
> index 7e315779e66480c2a3f2473a068278ab5e513a3d..e63dcf8d45567b0851393c2cea7a0d630afa20cd 100644
> --- a/drivers/net/ipa/data/ipa_data-v4.7.c
> +++ b/drivers/net/ipa/data/ipa_data-v4.7.c
> @@ -38,8 +38,8 @@ enum ipa_rsrc_group_id {
>   /* QSB configuration data for an SoC having IPA v4.7 */
>   static const struct ipa_qsb_data ipa_qsb_data[] = {
>   	[IPA_QSB_MASTER_DDR] = {
> -		.max_writes		= 8,
> -		.max_reads		= 0,	/* no limit (hardware max) */
> +		.max_writes		= 12,
> +		.max_reads		= 13,
>   		.max_reads_beats	= 120,
>   	},
>   };
>