linux-kernel - Re: [PATCH v3 0/6] ASoC: q6apm: fix under runs and fragment sizes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z8cyt2n7qj4GkcJC@hovoldconsulting.com>
Date: Tue, 4 Mar 2025 18:04:55 +0100
From: Johan Hovold <johan@...nel.org>
To: srinivas.kandagatla@...aro.org
Cc: broonie@...nel.org, perex@...ex.cz, tiwai@...e.com,
	krzysztof.kozlowski@...aro.org, linux-sound@...r.kernel.org,
	linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
	dmitry.baryshkov@...aro.org, johan+linaro@...nel.org
Subject: Re: [PATCH v3 0/6] ASoC: q6apm: fix under runs and fragment sizes

On Tue, Mar 04, 2025 at 10:57:17AM +0000, Srinivas Kandagatla wrote:
> From: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
> 
> On Qualcomm Audioreach setup, some of the audio artifacts are seen in
> both recording and playback. These patches fix issues by
> 1. Adjusting the fragment size that dsp can service.
> 2. schedule available playback buffers in time for dsp to not hit under runs 
> 3. remove some of the manual calculations done to get hardware pointer.
> 
> With these patches, am able to see Audio quality improvements.
> 
> Any testing would be appreciated.

This fixes the playback and capture issues with Pipewire, including the
heavily distorted, choppy playback when pavucontrol is open. Turns out
that the pavucontrol volume meters reduces the output sink quantum size
from the default 1024 to 256, which was too low with v2 but now seems to
work.

Unfortunately, this series still regresses Pulseaudio as capture is now
choppy (e.g. when recording using parecord).

During our off-list debugging sessions you suggested reducing the max
capture period size (that this series increases) to 6144 (same as min)
and that fixed the Pulseaudio capture issue. In v3 the, the max period
is again increased to 65536 which appears to break Pulseaudio capture.

> Changes since v2:
> 	- dropped patch which is causing regression with pluseaudio.
> 	- setup period sizes only for capture path
> 	- fix underruns/overruns in dsp pipelines.
> 	- add fixes tag
> 	- add patch to fix buffer alignment

Johan