linux-kernel - Re: [PATCH] mtd: rawnand: tegra: Simplify maximum determination in tegra_nand_setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87pliy9yyv.fsf@bootlin.com>
Date: Mon, 03 Mar 2025 11:43:04 +0100
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: Markus Elfring <Markus.Elfring@....de>
Cc: linux-tegra@...r.kernel.org,  linux-mtd@...ts.infradead.org,  Jonathan
 Hunter <jonathanh@...dia.com>,  Lucas Stach <dev@...xeye.de>,  Richard
 Weinberger <richard@....at>,  Stefan Agner <stefan@...er.ch>,  Thierry
 Reding <thierry.reding@...il.com>,  Vignesh Raghavendra <vigneshr@...com>,
  LKML <linux-kernel@...r.kernel.org>,  kernel-janitors@...r.kernel.org,
  Qasim Ijaz <qasdev00@...il.com>,  Natalie Vock <natalie.vock@....de>
Subject: Re: [PATCH] mtd: rawnand: tegra: Simplify maximum determination in
 tegra_nand_setup_timing()

Hi,

On 28/02/2025 at 19:33:10 +01, Markus Elfring <Markus.Elfring@....de> wrote:

> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Fri, 28 Feb 2025 19:19:45 +0100
>
> Reduce nested max() calls by a single max3() call in this
> function implementation.
>
> The source code was transformed by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>

I am sorry, I do not see what gets simplified. max(max(a,b),max(c,d))
looks simpler than max3(a,b,max(c,d)). Does it bring something in terms
of optimization?

Thanks,
Miquèl