linux-kernel - Re: [PATCH RESEND] drm/msm/dpu: Delete a variable initialisation before a null pointer check in two functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <29b32b0d-312d-4848-9e26-9e5e76e527a7@stanley.mountain>
Date: Mon, 3 Mar 2025 10:14:06 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
Cc: Markus Elfring <Markus.Elfring@....de>, kernel-janitors@...r.kernel.org,
	freedreno@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
	linux-arm-msm@...r.kernel.org,
	Abhinav Kumar <quic_abhinavk@...cinc.com>,
	Archit Taneja <architt@...eaurora.org>,
	Daniel Vetter <daniel@...ll.ch>, David Airlie <airlied@...il.com>,
	Jeykumar Sankaran <jsanka@...eaurora.org>,
	Jordan Crouse <jordan@...micpenguin.net>,
	Marijn Suijten <marijn.suijten@...ainline.org>,
	Rob Clark <robdclark@...il.com>, Sean Paul <sean@...rly.run>,
	Simona Vetter <simona@...ll.ch>, Vinod Koul <vkoul@...nel.org>,
	cocci@...ia.fr, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH RESEND] drm/msm/dpu: Delete a variable initialisation
 before a null pointer check in two functions

On Mon, Mar 03, 2025 at 01:01:40AM +0200, Dmitry Baryshkov wrote:
> On Sun, Mar 02, 2025 at 09:56:00PM +0100, Markus Elfring wrote:
> > From: Markus Elfring <elfring@...rs.sourceforge.net>
> > Date: Tue, 11 Apr 2023 18:24:24 +0200
> > 
> > The address of a data structure member was determined before
> > a corresponding null pointer check in the implementation of
> > the functions “dpu_hw_pp_enable_te” and “dpu_hw_pp_get_vsync_info”.
> > 
> > Thus avoid the risk for undefined behaviour by removing extra
> > initialisations for the variable “c” (also because it was already
> > reassigned with the same value behind this pointer check).

There is no undefined behavior here.

> > 
> > This issue was detected by using the Coccinelle software.
> 
> Please don't send resends and/or new iterations in response to your
> previous patchsets. Otherwise they have a pretty high chance to be
> ignored by the maintainers. Use a fresh git-send-email command to send
> new patchset.
> 
> > 
> > Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support")

Remove the Fixes tag.  This patch is fine as a clean up.

> > Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>

regards,
dan carpenter