linux-kernel - Re: [PATCH 3/4] staging: gpib: fix kernel-doc section for usb_gpib_line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <mcagpfhzrwlvys76ketpo33l5yn2ij2csshrzz3tgufrdr5lg3@i4nmisbi3l6f>
Date: Tue, 4 Mar 2025 16:33:09 -0300
From: Gaston Gonzalez <gascoar@...il.com>
To: linux-staging@...ts.linux.dev
Cc: dpenkler@...il.com, gregkh@...uxfoundation.org, 
	dan.carpenter@...aro.org, arnd@...db.de, niharchaithanya@...il.com, 
	jiapeng.chong@...ux.alibaba.com, linux-kernel@...r.kernel.org, gascoar@...il.com
Subject: Re: [PATCH 3/4] staging: gpib: fix kernel-doc section for
 usb_gpib_line_status() function

On Tue, Mar 04, 2025 at 04:25:41PM -0300, Gaston Gonzalez wrote:
> The function name field in the kernel-doc section for the
> usb_gpib_line_status() is defined as 'line_status'. In addition, after
> the kernel-doc section, there are three macro definition instead of the
> function definition.
> 
> These issues trigger the warning:
> 
> warning: expecting prototype for line_status(). Prototype was for WQT()
> instead.
> 
> Fix the warning by renaming the function in the kernel-doc section and
> by moving the macros at the beginning of the file with the rest of
> macros definition.
> 
> Signed-off-by: Gaston Gonzalez <gascoar@...il.com>
> ---
>  drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c b/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c
> index 090857824d07..f7dd0809b06c 100644
> --- a/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c
> +++ b/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c
> @@ -78,6 +78,10 @@ module_param(debug, int, 0644);
>  			dev_dbg(board->gpib_dev, format, ## __VA_ARGS__); } \
>  	while (0)
>  
> +#define WQT wait_queue_entry_t
> +#define WQH head
> +#define WQE entry
> +
>  /* standard and extended command sets of the usb-gpib adapter */
>  
>  #define USB_GPIB_ON	 "\nIB\n"
> @@ -131,6 +135,7 @@ module_param(debug, int, 0644);
>  
>  #define INBUF_SIZE 128
>  
> +

Please disregard this patch. I noticed this blank line after I sent the
patch.

Will resend.

Gaston


>  struct char_buf {		/* used by one_char() routine */
>  	char *inbuf;
>  	int last;
> @@ -644,17 +649,12 @@ static void usb_gpib_interface_clear(gpib_board_t *board, int assert)
>  }
>  
>  /**
> - * line_status() - Read the status of the bus lines.
> + * usb_gpib_line_status() - Read the status of the bus lines.
>   *
>   *  @board:    the gpib_board data area for this gpib interface
>   *
>   *    We can read all lines.
>   */
> -
> -#define WQT wait_queue_entry_t
> -#define WQH head
> -#define WQE entry
> -
>  static int usb_gpib_line_status(const gpib_board_t *board)
>  {
>  	int buffer;
> -- 
> 2.49.0.rc0
>