linux-kernel - Re: [PATCH] HID: lenovo: silence unreachable code warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4r6151p3-6q5p-1915-64o3-oo505p6674qp@xreary.bet>
Date: Tue, 4 Mar 2025 21:14:50 +0100 (CET)
From: Jiri Kosina <jikos@...nel.org>
To: Dan Carpenter <dan.carpenter@...aro.org>
cc: Arnd Bergmann <arnd@...db.de>, Benjamin Tissoires <bentiss@...nel.org>, 
    linux-input@...r.kernel.org, linux-kernel@...r.kernel.org, 
    kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] HID: lenovo: silence unreachable code warning

On Thu, 6 Feb 2025, Dan Carpenter wrote:

> In theory, this code used to return 0 if CONFIG_ACPI_PLATFORM_PROFILE was
> disabled.  It's not clear if that was a config which would actually boot
> so we've removed the CONFIG_ACPI_PLATFORM_PROFILE ifdef.  But now the
> "return 0;" statement is unreachable and static checker tools complain.
> 
> Delete it and pull the else statement in a tab to silence the checker
> warning and make the code a bit more clear.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>

Applied, thanks Dan.

-- 
Jiri Kosina
SUSE Labs