linux-kernel - Re: [PATCH v2 1/4] HID: apple: Use common table for MacBook Pro fn mapping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <sp111ppn-q3pn-20rp-92n0-rqn0p2s7s7n5@xreary.bet>
Date: Tue, 4 Mar 2025 21:23:38 +0100 (CET)
From: Jiri Kosina <jikos@...nel.org>
To: Aditya Garg <gargaditya08@...e.com>
cc: Benjamin Tissoires <benjamin.tissoires@...hat.com>, 
    "bentiss@...nel.org" <bentiss@...nel.org>, 
    Alex Henrie <alexhenrie24@...il.com>, 
    "jose.exposito89@...il.com" <jose.exposito89@...il.com>, 
    "bruners@...il.com" <bruners@...il.com>, 
    "seobrien@...omium.org" <seobrien@...omium.org>, 
    Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, 
    "linux-input@...r.kernel.org" <linux-input@...r.kernel.org>
Subject: Re: [PATCH v2 1/4] HID: apple: Use common table for MacBook Pro fn
 mapping

On Fri, 14 Feb 2025, Aditya Garg wrote:

> From: Aditya Garg <gargaditya08@...e.com>
> 
> The only difference between the fn mapping of the MacBook Pros with esc key
> and those without is of the presence of KEY_GRAVE in the translation table.
> 
> We can easily use a flag instead of writing the whole table again to omit
> it from the models that have an esc key.
> 
> Additionally, APPLE_IGNORE_MOUSE quirk was unused in this driver, so has
> been removed in this commit.
> 
> Signed-off-by: Aditya Garg <gargaditya08@...e.com>
> ---
> drivers/hid/hid-apple.c | 72 ++++++++++++++++-------------------------
> 1 file changed, 27 insertions(+), 45 deletions(-)
> 
> diff --git a/drivers/hid/hid-apple.c b/drivers/hid/hid-apple.c
> index 49812a76b..e31c9e8e8 100644
> --- a/drivers/hid/hid-apple.c
> +++ b/drivers/hid/hid-apple.c
> @@ -30,7 +30,7 @@
> #include "hid-ids.h"
> 
> #define APPLE_RDESC_JIS		BIT(0)
> -#define APPLE_IGNORE_MOUSE	BIT(1)
> +/* BIT(1) reserved, was: APPLE_IGNORE_MOUSE */
> #define APPLE_HAS_FN		BIT(2)
> /* BIT(3) reserved, was: APPLE_HIDDEV */
> #define APPLE_ISO_TILDE_QUIRK	BIT(4)
> @@ -43,7 +43,8 @@
> #define APPLE_IS_NON_APPLE	BIT(11)
> #define APPLE_MAGIC_BACKLIGHT	BIT(12)

This patch is corrupt -- the context lines are missing the leading space. 
For some reason, it's only the 1/4 which is corrupted, the rest is fine.

Can you please look into this and resubmit?

Thanks,

-- 
Jiri Kosina
SUSE Labs