linux-kernel - Re: [PATCH V6 2/2] checkpatch: check format of Vec<String> in modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250304205054.207285-1-trintaeoitogc@gmail.com>
Date: Tue,  4 Mar 2025 17:50:54 -0300
From: Guilherme Giacomo Simoes <trintaeoitogc@...il.com>
To: a.hindborg@...nel.org
Cc: alex.gaynor@...il.com,
	aliceryhl@...gle.com,
	apw@...onical.com,
	arnd@...db.de,
	aswinunni01@...il.com,
	axboe@...nel.dk,
	benno.lossin@...ton.me,
	bhelgaas@...gle.com,
	bjorn3_gh@...tonmail.com,
	boqun.feng@...il.com,
	dakr@...nel.org,
	dwaipayanray1@...il.com,
	ethan.twardy@...il.com,
	fujita.tomonori@...il.com,
	gary@...yguo.net,
	gregkh@...uxfoundation.org,
	joe@...ches.com,
	linux-kernel@...r.kernel.org,
	lukas.bulwahn@...il.com,
	ojeda@...nel.org,
	pbonzini@...hat.com,
	rust-for-linux@...r.kernel.org,
	tmgross@...ch.edu,
	trintaeoitogc@...il.com,
	walmeida@...rosoft.com
Subject: Re: [PATCH V6 2/2] checkpatch: check format of Vec<String> in modules

Andreas Hindborg <a.hindborg@...nel.org> wrote:
> Does what it says on the label. However, indentation is not checked and
> the following is passing:
> 
>     authors: [
>         "John Doe",
>               "Foo Bar"
>     ],
> 
You is right, maybe is good doing this?

> Another thing: I'm wondering if we could have a rust hostprog to do
> this check, rather than a perl script?
hostprog like rustfmt?
About this, Daniel Sedlak say:
"I think we could fight with the code formatting, because when it comes 
to the rust macros, rustfmt is often very confused and we could end up 
with variations like:

	authors: ["author1", "author2",
			"author3"]

or

	authors: [
		   "author1",
		   "author2",
		  ]
"

Thanks,
Guilherme