linux-kernel - Re: [PATCH v7 01/15] crypto: acomp - Add synchronous/asynchronous acomp request chaining.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z8aNY5TFj_-os4Fd@gondor.apana.org.au>
Date: Tue, 4 Mar 2025 13:19:31 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Kanchana P Sridhar <kanchana.p.sridhar@...el.com>
Cc: linux-kernel@...r.kernel.org, linux-mm@...ck.org, hannes@...xchg.org,
	yosry.ahmed@...ux.dev, nphamcs@...il.com, chengming.zhou@...ux.dev,
	usamaarif642@...il.com, ryan.roberts@....com, 21cnbao@...il.com,
	ying.huang@...ux.alibaba.com, akpm@...ux-foundation.org,
	linux-crypto@...r.kernel.org, davem@...emloft.net,
	clabbe@...libre.com, ardb@...nel.org, ebiggers@...gle.com,
	surenb@...gle.com, kristen.c.accardi@...el.com,
	wajdi.k.feghali@...el.com, vinodh.gopal@...el.com
Subject: Re: [PATCH v7 01/15] crypto: acomp - Add synchronous/asynchronous
 acomp request chaining.

On Fri, Feb 28, 2025 at 02:00:10AM -0800, Kanchana P Sridhar wrote:
>
>  Step 2: Process the request chain using the specified compress/decompress
>          "op":
> 
>   2.a) Synchronous: the chain of requests is processed in series:
> 
>        int acomp_do_req_chain(struct acomp_req *req,
>                               int (*op)(struct acomp_req *req));
> 
>   2.b) Asynchronous: the chain of requests is processed in parallel using a
>        submit-poll paradigm:
> 
>        int acomp_do_async_req_chain(struct acomp_req *req,
>                                     int (*op_submit)(struct acomp_req *req),
>                                     int (*op_poll)(struct acomp_req *req));
> 
> Request chaining will be used in subsequent patches to implement
> compress/decompress batching in the iaa_crypto driver for the two supported
> IAA driver sync_modes:
> 
>   sync_mode = 'sync' will use (2.a),
>   sync_mode = 'async' will use (2.b).

There shouldn't be any sync/async toggle.  The whole zswap code is
synchronous only and it makes zero sense to expose this to the user.
Just do whatever is the fastest from the driver's point of view.

I've actually implemented acomp chaining in my tree and I will be
reposting soon.

Cheers,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt