linux-kernel - Re: [PATCH v7 3/5] Add debugfs based silicon debug support in DWC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250304064452.GA2615015@rocinante>
Date: Tue, 4 Mar 2025 15:44:52 +0900
From: Krzysztof Wilczyński <kw@...ux.com>
To: Fan Ni <nifan.cxl@...il.com>
Cc: Shradha Todi <shradha.t@...sung.com>, linux-kernel@...r.kernel.org,
	linux-pci@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-perf-users@...r.kernel.org, manivannan.sadhasivam@...aro.org,
	lpieralisi@...nel.org, robh@...nel.org, bhelgaas@...gle.com,
	jingoohan1@...il.com, Jonathan.Cameron@...wei.com,
	a.manzanares@...sung.com, pankaj.dubey@...sung.com,
	cassel@...nel.org, 18255117159@....com, xueshuai@...ux.alibaba.com,
	renyu.zj@...ux.alibaba.com, will@...nel.org, mark.rutland@....com
Subject: Re: [PATCH v7 3/5] Add debugfs based silicon debug support in DWC

Hello,

[...]
> > > What will happen if ret != 0? still return 0? 
> > 
> > Given that callers of dwc_pcie_debugfs_init() check for errors,
> > this probably should correctly bubble up any failure coming from
> > dwc_pcie_rasdes_debugfs_init().
> > 
> > I made updates to the code directly on the current branch, have a look:
> > 
> >   https://web.git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git/commit/?h=controller/dwc&id=1ff54f4cbaed9ec6994844967c36cf7ada4cbe5e
> > 
> > Let me know if this is OK with you.
> 
> It looks good to me.
> 
> Feel free to add,
> Reviewed-by: Fan Ni <fan.ni@...sung.com>

Will do.  Thank you.

	Krzysztof