linux-kernel - Re: [PATCH v2 1/2] irqdomain: support three-cell scheme interrupts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250304073901-GYA60841@gentoo>
Date: Tue, 4 Mar 2025 07:39:01 +0000
From: Yixun Lan <dlan@...too.org>
To: Linus Walleij <linus.walleij@...aro.org>
Cc: Thomas Gleixner <tglx@...utronix.de>,
	Bartosz Golaszewski <brgl@...ev.pl>,
	Alex Elder <elder@...cstar.com>,
	Inochi Amaoto <inochiama@...il.com>, linux-kernel@...r.kernel.org,
	linux-gpio@...r.kernel.org, linux-riscv@...ts.infradead.org,
	spacemit@...ts.linux.dev, Rob Herring <robh@...nel.org>
Subject: Re: [PATCH v2 1/2] irqdomain: support three-cell scheme interrupts

Hi Linus Walleij:

On 08:31 Tue 04 Mar     , Linus Walleij wrote:
> On Mon, Mar 3, 2025 at 1:40 PM Yixun Lan <dlan@...too.org> wrote:
> > On 19:30 Sun 02 Mar     , Thomas Gleixner wrote:
> 
> > > Why is the three cell translation not following the one/two cell scheme
> > > and has the parameters at the same place (index 0,1), i.e. adding the
> > > extra information at the end? That makes sense to me as the extra cell
> > > is obviously not directly related to the interrupt mapping.
> >
> > I think we currently just following the scheme with gpio cells order
> > scheme, which is (index(instance) offset flag..), the index and offset
> > are parameters to locate the irq which can easily derive from global
> > gpio pin number, so I thought it's more intuitive to group them
> > orderly together..
> 
> Right, the DT bindings are mainly for human consumption, and the
> cells are positioned in left-to-right intuitive order.
> 
> If they were only for machines it would be another issue, but it's
> people who have to write and maintain these files.
> 
> For example, in a library a machine could arrange books by
> first letter in the title, then by second letter in the title etc, but
> that would be very confusing for humans who expect to find
> them in author order.
> 
> There are many examples of this in the DT bindings.
> 
Ok, I got your idea.. thanks
I will rework the patch to address Thomas's concern

> Yours,
> Linus Walleij
> 

-- 
Yixun Lan (dlan)
Gentoo Linux Developer
GPG Key ID AABEFD55