linux-kernel - Re: [PATCH v2 03/12] iommu: Remove IOMMU_DEV_FEAT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c9c03027-dabb-4a03-9bb8-fbbf54fcd7db@intel.com>
Date: Tue, 4 Mar 2025 15:50:12 +0800
From: Yi Liu <yi.l.liu@...el.com>
To: Lu Baolu <baolu.lu@...ux.intel.com>, Joerg Roedel <joro@...tes.org>, "Will
 Deacon" <will@...nel.org>, Robin Murphy <robin.murphy@....com>, "Jason
 Gunthorpe" <jgg@...pe.ca>, Kevin Tian <kevin.tian@...el.com>
CC: Dave Jiang <dave.jiang@...el.com>, Vinod Koul <vkoul@...nel.org>, "Fenghua
 Yu" <fenghuay@...dia.com>, Zhangfei Gao <zhangfei.gao@...aro.org>, Zhou Wang
	<wangzhou1@...ilicon.com>, <iommu@...ts.linux.dev>,
	<linux-kernel@...r.kernel.org>, Jason Gunthorpe <jgg@...dia.com>
Subject: Re: [PATCH v2 03/12] iommu: Remove IOMMU_DEV_FEAT_SVA

On 2025/2/24 13:16, Lu Baolu wrote:
> From: Jason Gunthorpe <jgg@...dia.com>
> 
> None of the drivers implement anything here anymore, remove the dead code.
> 
> Signed-off-by: Jason Gunthorpe <jgg@...dia.com>
> Signed-off-by: Lu Baolu <baolu.lu@...ux.intel.com>
> ---
>   drivers/accel/amdxdna/aie2_pci.c            | 13 ++-----------
>   drivers/dma/idxd/init.c                     |  8 +-------
>   drivers/iommu/amd/iommu.c                   |  2 --
>   drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c |  2 --
>   drivers/iommu/intel/iommu.c                 |  6 ------
>   drivers/iommu/iommu-sva.c                   |  3 ---
>   drivers/misc/uacce/uacce.c                  |  9 ---------
>   include/linux/iommu.h                       |  9 +--------
>   8 files changed, 4 insertions(+), 48 deletions(-)

Reviewed-by: Yi Liu <yi.l.liu@...el.com>

with a nit:


> diff --git a/drivers/dma/idxd/init.c b/drivers/dma/idxd/init.c
> index b946f78f85e1..1e5038cca22c 100644
> --- a/drivers/dma/idxd/init.c
> +++ b/drivers/dma/idxd/init.c
> @@ -633,17 +633,11 @@ static int idxd_enable_sva(struct pci_dev *pdev)
>   	ret = iommu_dev_enable_feature(&pdev->dev, IOMMU_DEV_FEAT_IOPF);
>   	if (ret)

delete this check, and return ret.

>   		return ret;
> -
> -	ret = iommu_dev_enable_feature(&pdev->dev, IOMMU_DEV_FEAT_SVA);
> -	if (ret)
> -		iommu_dev_disable_feature(&pdev->dev, IOMMU_DEV_FEAT_IOPF);
> -
> -	return ret;
> +	return 0;

-- 
Regards,
Yi Liu