lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ihojf2rvfg3nqebovaf7vsc57uwolxnyodkutva64zxptukgv7@wqu3nnbi3yzt>
Date: Tue, 4 Mar 2025 09:00:12 +0800
From: Inochi Amaoto <inochiama@...il.com>
To: Conor Dooley <conor@...nel.org>, Inochi Amaoto <inochiama@...il.com>
Cc: Thomas Gleixner <tglx@...utronix.de>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Chen Wang <unicorn_wang@...look.com>, linux-kernel@...r.kernel.org, devicetree@...r.kernel.org, 
	sophgo@...ts.linux.dev, Yixun Lan <dlan@...too.org>, Longbin Li <looong.bin@...il.com>
Subject: Re: [PATCH 1/2] dt-bindings: interrupt-controller: Add Sophgo SG2044
 MSI controller

On Mon, Mar 03, 2025 at 04:29:53PM +0000, Conor Dooley wrote:
> On Mon, Mar 03, 2025 at 07:16:46PM +0800, Inochi Amaoto wrote:
> > Like SG2042, SG2044 uses a similar msi controller to provide MSI
> > interrupt for PCIe controllers.
> 
> In the future, could you mention the way in which they differ?
> "similar" could mean 99% the same but incompatible, or 90% the same but
> capable of using a fallback?
> Acked-by: Conor Dooley <conor.dooley@...rochip.com>
> 

It is OK for me. The difference between these two controller
are the number of MSI interrupts supports, and the way to
mask/map MSI message.

I will update the comment message for it.

Regards,
Inochi


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ