linux-kernel - Re: [PATCH 05/11] drm/msm/dsi: add DSI support for SA8775P

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <91934960-c9fc-4442-88f3-ba1371470d05@quicinc.com>
Date: Tue, 4 Mar 2025 15:00:25 +0530
From: Ayushi Makhija <quic_amakhija@...cinc.com>
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
CC: <linux-arm-msm@...r.kernel.org>, <dri-devel@...ts.freedesktop.org>,
        <freedreno@...ts.freedesktop.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <robdclark@...il.com>,
        <sean@...rly.run>, <marijn.suijten@...ainline.org>,
        <andersson@...nel.org>, <robh@...nel.org>, <robh+dt@...nel.org>,
        <krzk+dt@...nel.org>, <konradybcio@...nel.org>, <conor+dt@...nel.org>,
        <andrzej.hajda@...el.com>, <neil.armstrong@...aro.org>,
        <rfoss@...nel.org>, <Laurent.pinchart@...asonboard.com>,
        <jonas@...boo.se>, <jernej.skrabec@...il.com>,
        <quic_abhinavk@...cinc.com>, <quic_rajeevny@...cinc.com>,
        <quic_vproddut@...cinc.com>, <quic_jesszhan@...cinc.com>
Subject: Re: [PATCH 05/11] drm/msm/dsi: add DSI support for SA8775P

On 2/25/2025 10:48 PM, Dmitry Baryshkov wrote:
> On Tue, Feb 25, 2025 at 05:48:18PM +0530, Ayushi Makhija wrote:
>> Add DSI Controller v2.5.1 support for SA8775P SoC.
>>
>> Signed-off-by: Ayushi Makhija <quic_amakhija@...cinc.com>
>> ---
>>  drivers/gpu/drm/msm/dsi/dsi_cfg.c | 18 ++++++++++++++++++
>>  drivers/gpu/drm/msm/dsi/dsi_cfg.h |  1 +
>>  2 files changed, 19 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/msm/dsi/dsi_cfg.c b/drivers/gpu/drm/msm/dsi/dsi_cfg.c
>> index 7754dcec33d0..71881d9370af 100644
>> --- a/drivers/gpu/drm/msm/dsi/dsi_cfg.c
>> +++ b/drivers/gpu/drm/msm/dsi/dsi_cfg.c
>> @@ -221,6 +221,22 @@ static const struct msm_dsi_config sc7280_dsi_cfg = {
>>  	},
>>  };
>>  
>> +static const struct regulator_bulk_data sa8775p_dsi_regulators[] = {
>> +	{ .supply = "vdda", .init_load_uA = 30100 },    /* 1.2 V */
>> +	{ .supply = "refgen" },
>> +};
> 
> sc7280 has 8350 uA here. I'd say, having those two next to each other is
> suspicious. Could you please doublecheck it?
> 
> LGTM otherwise
> 

Hi Dmitry,
Thanks, for the review.

This chipset is being used in Auto, and I have taken the init load values from the downstream code.
After you raised the doubt, I checked in the power grid for the DSI ctrl 1p2 supply (mdss0_dsi0 && mdss0_dsi1) and found the load is 8300 uA. 
I also checked DSI PHY 0p9 supply (mdss0_dsi0_phy & mdss0_dsi1_phy) load and it seems the downstream SW values are incorrect for the PHY as well.
Correct value for 0p9 supply as per the Power grid is 48000 uA. 
I have tested using update load and it's working fine. I will update the both in my next patchset.

Thanks,
Ayushi