linux-kernel - Re: [PATCH v2 0/2] spi: sophgo: add Sophgo SPI NOR controller driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <PN0PR01MB10393099D28CF3DF75A0F414CFEC82@PN0PR01MB10393.INDPRD01.PROD.OUTLOOK.COM>
Date: Tue, 4 Mar 2025 18:14:54 +0800
From: Chen Wang <unicorn_wang@...look.com>
To: Longbin Li <looong.bin@...il.com>, Mark Brown <broonie@...nel.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Paul Walmsley
 <paul.walmsley@...ive.com>, Palmer Dabbelt <palmer@...belt.com>,
 Albert Ou <aou@...s.berkeley.edu>, Inochi Amaoto <inochiama@...il.com>
Cc: linux-spi@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-riscv@...ts.infradead.org,
 sophgo@...ts.linux.dev
Subject: Re: [PATCH v2 0/2] spi: sophgo: add Sophgo SPI NOR controller driver


On 2025/3/4 16:35, Longbin Li wrote:
> Add SPI NOR driver for Sophgo, including read, write operations.
> This driver is only suitable for NOR flash.
If there is a next patchset, please also replace "Sopgho" with "SG2044" 
in the cover letter, including the email title.
> ---
>
> Changes in v2:
>
>    Fixed following issues as per comments from Yixun Lan, Chen Wang, Inochi Amaoto, thanks.

I feel like you left out Rob, and you also left out his signature in the 
first patch ;)

>
>    - Replaced "sophgo" to "sg2044" to avoid conflicts with other drivers.
>    - Improve driver code:
>      - Improve coding style.
>      - Removed the [PATCH 3/3] in previous submission that based on the baseline not submitted.
>      - Added error handler to destroy mutex if probe fail.
>
> Changes in v1:
>    You can simply review or test the patches at the link [1].
>
> Link: https://lore.kernel.org/linux-riscv/20250224101213.26003-1-looong.bin@gmail.com/ [1]
> ---
>
> Longbin Li (2):
>    dt-bindings: spi: add SG2044 SPI NOR controller driver
>    spi: sophgo: add SG2044 SPI NOR controller driver
>
>   .../bindings/spi/spi-sg2044-nor.yaml          |  52 ++
>   drivers/spi/Kconfig                           |   9 +
>   drivers/spi/Makefile                          |   1 +
>   drivers/spi/spi-sg2044-nor.c                  | 500 ++++++++++++++++++
>   4 files changed, 562 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/spi/spi-sg2044-nor.yaml
>   create mode 100644 drivers/spi/spi-sg2044-nor.c
>
> --
> 2.48.1