linux-kernel - Re: [PATCH] iio: Mark iio_dev as const in getter methods

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250305125612.28ac7bc9@jic23-huawei>
Date: Wed, 5 Mar 2025 12:56:12 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: Jorge Marques <jorge.marques@...log.com>
Cc: Lars-Peter Clausen <lars@...afoo.de>, <linux-iio@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] iio: Mark iio_dev as const in getter methods

On Mon, 3 Mar 2025 15:46:25 +0100
Jorge Marques <jorge.marques@...log.com> wrote:

> get_current_scan_type read-only method allows to support multiple
> scan types per channel, which may also depend on a buffer enabled state.
> Mark iio_dev as const in iio_device_id, iio_device_get_current_mode,
> iio_buffer_enabled read-only methods so they can be used from other
> read-only methods.
> 
> Signed-off-by: Jorge Marques <jorge.marques@...log.com>

Hi Jorge,

I'm not against this, but I would like to see this patch as part of
a series that uses it from a read-only method.

Until then this looks like noise unless there is other reasoning.

Thanks,

Jonathan