linux-kernel - Re: [PATCH 01/22] rust: init: disable doctests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72kUwxNCao1-3AeBfzWQu5rjaHMMA6vzXXudD=5NxC869g@mail.gmail.com>
Date: Wed, 5 Mar 2025 14:00:28 +0100
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Benno Lossin <benno.lossin@...ton.me>
Cc: Andreas Hindborg <a.hindborg@...nel.org>, Miguel Ojeda <ojeda@...nel.org>, 
	Alex Gaynor <alex.gaynor@...il.com>, Boqun Feng <boqun.feng@...il.com>, 
	Gary Guo <gary@...yguo.net>, Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>, 
	Danilo Krummrich <dakr@...nel.org>, rust-for-linux@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 01/22] rust: init: disable doctests

On Wed, Mar 5, 2025 at 1:53 PM Benno Lossin <benno.lossin@...ton.me> wrote:
>
> Thanks for pointing that out, any suggestions for this concrete case? I
> wasn't able to come up with an imperative statement.

Normally I follow a "Context, Why, (thus) What, Alternatives, Future"
format or similar.

The imperative is meant for the "What" part, i.e. the actual change
you are performing, which you already do in "..., ignore all doctests
...", so that looks fine to me.

You could just remove the first line, or perhaps move it and reword it
with ", in order to..." after the "ignore" sentence.

Cheers,
Miguel