linux-kernel - Re: [PATCH] scsi: hisi: remove incorrect ACPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c75288a5-9e3c-e4c7-4717-9c04348dc7d4@huawei.com>
Date: Wed, 5 Mar 2025 09:36:25 +0800
From: Yihang Li <liyihang9@...wei.com>
To: Uwe Kleine-König <u.kleine-koenig@...libre.com>
CC: Arnd Bergmann <arnd@...nel.org>, "James E.J. Bottomley"
	<James.Bottomley@...senpartnership.com>, "Martin K. Petersen"
	<martin.petersen@...cle.com>, Arnd Bergmann <arnd@...db.de>, Damien Le Moal
	<dlemoal@...nel.org>, John Garry <john.g.garry@...cle.com>, Bart Van Assche
	<bvanassche@....org>, Jason Yan <yanaijie@...wei.com>, Igor Pylypiv
	<ipylypiv@...gle.com>, <linux-scsi@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <liyihang9@...wei.com>
Subject: Re: [PATCH] scsi: hisi: remove incorrect ACPI_PTR annotations



On 2025/3/4 13:12, Uwe Kleine-König wrote:
> Hello,
> 
> On Wed, Feb 26, 2025 at 11:23:18AM +0800, Yihang Li wrote:
>> On 2025/2/26 0:36, Arnd Bergmann wrote:
>>> From: Arnd Bergmann <arnd@...db.de>
>>>
>>> Building with W=1 shows a warning about sas_v2_acpi_match being unused when
>>> CONFIG_OF is disabled:
>>>
>>>     drivers/scsi/hisi_sas/hisi_sas_v2_hw.c:3635:36: error: unused variable 'sas_v2_acpi_match' [-Werror,-Wunused-const-variable]
>>>
>>> Signed-off-by: Arnd Bergmann <arnd@...db.de>
>>
>> Looks good. So Reviewed-by: Yihang Li <liyihang9@...wei.com>
> 
> If you put your Reviewed-by tag in a separate line, the tooling that
> most maintainers use pick it up automatically. Martin applied your patch
> (currently as commit 7a9c0476d4073e742f474e71feeef4f54add4bc9 in
> https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git 6.15/scsi-staging
> ) indeed without your tag.
> 

Ok, thanks for the reminder. I'll pay attention next time.

Thanks
Yihang