linux-kernel - Re: [PATCH] f2fs: support F2FS_NOLINEAR_LOOKUP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z8hj2g_fj1zH1t_m@infradead.org>
Date: Wed, 5 Mar 2025 06:46:50 -0800
From: Christoph Hellwig <hch@...radead.org>
To: Eric Biggers <ebiggers@...nel.org>
Cc: Chao Yu <chao@...nel.org>, jaegeuk@...nel.org,
	linux-kernel@...r.kernel.org,
	linux-f2fs-devel@...ts.sourceforge.net,
	linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH] f2fs: support F2FS_NOLINEAR_LOOKUP_FL

On Mon, Mar 03, 2025 at 11:06:44PM +0000, Eric Biggers wrote:
> > +/* used for FS_IOC_GETFLAGS and FS_IOC_SETFLAGS */
> > +enum {
> > +	F2FS_NOLINEAR_LOOKUP_FLAG = 0x08000000,
> > +};
> 
> FS_IOC_GETFLAGS and FS_IOC_SETFLAGS are not filesystem-specific, and the
> supported flags are declared in include/uapi/linux/fs.h.  You can't just
> randomly give an unused bit a filesystem specific meaning.

Eww, yes.  This needs to be reverted ASAP.

And I'd like to repeat my reminder that we need to stop file systems
(and f2fs is particularly bad for this) to stop just adding random
uapis without review from linux-fsdevel and linux-api.