linux-kernel - Re: [PATCH v2 3/6] sysctl/coda: Fixes timeout bounds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ukkrk6tcf4peempwyutpruupqjkyrbeizrqz2ymjsjpmj6tds5@zb5vp5rh7qoe>
Date: Wed, 5 Mar 2025 15:47:39 +0100
From: Joel Granados <joel.granados@...nel.org>
To: Jan Harkes <jaharkes@...cmu.edu>
Cc: nicolas.bouchinet@...p-os.org, linux-kernel@...r.kernel.org, 
	linux-rdma@...r.kernel.org, linux-scsi@...r.kernel.org, linux-nfs@...r.kernel.org, 
	Nicolas Bouchinet <nicolas.bouchinet@....gouv.fr>, Joel Granados <j.granados@...sung.com>, 
	Clemens Ladisch <clemens@...isch.de>, Arnd Bergmann <arnd@...db.de>, 
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Jason Gunthorpe <jgg@...pe.ca>, 
	Leon Romanovsky <leon@...nel.org>, "James E.J. Bottomley" <James.Bottomley@...senpartnership.com>, 
	"Martin K. Petersen" <martin.petersen@...cle.com>, Chuck Lever <chuck.lever@...cle.com>, 
	Jeff Layton <jlayton@...nel.org>, Neil Brown <neilb@...e.de>, 
	Olga Kornievskaia <okorniev@...hat.com>, Dai Ngo <Dai.Ngo@...cle.com>, Tom Talpey <tom@...pey.com>, 
	Trond Myklebust <trondmy@...nel.org>, Anna Schumaker <anna@...nel.org>, 
	Bart Van Assche <bvanassche@....org>, Zhu Yanjun <yanjun.zhu@...ux.dev>, 
	Al Viro <viro@...iv.linux.org.uk>, Christian Brauner <brauner@...nel.org>
Subject: Re: [PATCH v2 3/6] sysctl/coda: Fixes timeout bounds

On Mon, Mar 03, 2025 at 09:39:37AM -0500, Jan Harkes wrote:
> On Mon, Mar 03, 2025 at 09:16:10AM -0500, Joel Granados wrote:
> > On Mon, Feb 24, 2025 at 10:58:18AM +0100, nicolas.bouchinet@...p-os.org wrote:
> > > From: Nicolas Bouchinet <nicolas.bouchinet@....gouv.fr>
> > > 
> > > Bound coda timeout sysctl writings between SYSCTL_ZERO
> > > and SYSCTL_INT_MAX.
> > > 
> > > The proc_handler has thus been updated to proc_dointvec_minmax.
> > > 
> > > Signed-off-by: Nicolas Bouchinet <nicolas.bouchinet@....gouv.fr>
> > > ---
> > >  fs/coda/sysctl.c | 4 +++-
> > >  1 file changed, 3 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/fs/coda/sysctl.c b/fs/coda/sysctl.c
> > > index 0df46f09b6cc5..d6f8206c51575 100644
> > > --- a/fs/coda/sysctl.c
> > > +++ b/fs/coda/sysctl.c
> > > @@ -20,7 +20,9 @@ static const struct ctl_table coda_table[] = {
> > >  		.data		= &coda_timeout,
> > I noticed that coda_timeout is an unsigned long. With that in mind I
> > would change it to unsigned int. It seems to be a value that can be
> > ranged within [0,INT_MAX]
> 
> That seems fine by me.
> 
> It is a timeout in seconds and it is typically set to some value well
> under a minute.
> 

Thx for the confirmation. I'll let nicolas take care of the change
Best

-- 

Joel Granados