linux-kernel - Re: [PATCH] power: energy_model: Rework the depends on for CONFIG_ENERGY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZ5v0j3+TFB22FKcGMdy6bfvczAcp+egWv5WjY9dWmHKh8fpA@mail.gmail.com>
Date: Wed, 5 Mar 2025 15:57:32 +0100
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Lukasz Luba <lukasz.luba@....com>, Xuewen Yan <xuewen.yan94@...il.com>
Cc: Xuewen Yan <xuewen.yan@...soc.com>, linux-pm@...r.kernel.org, len.brown@...el.com, 
	linux-kernel@...r.kernel.org, ke.wang@...soc.com, jeson.gao@...soc.com, 
	di.shen@...soc.com, pavel@....cz
Subject: Re: [PATCH] power: energy_model: Rework the depends on for CONFIG_ENERGY_MODEL

Hi,

On Wed, Mar 5, 2025 at 10:51 AM Lukasz Luba <lukasz.luba@....com> wrote:
>
> Hi Rafael,
>
> On 2/13/25 02:18, Xuewen Yan wrote:
> > Hi Rafael,
> >
> > I noticed that this patch has not been merged yet. Do you have any comments?
> >
> > BR
> >
> > On Thu, Dec 19, 2024 at 5:17 PM Lukasz Luba <lukasz.luba@....com> wrote:
> >>
> >>
> >>
> >> On 12/19/24 09:11, Xuewen Yan wrote:
> >>> From: Jeson Gao <jeson.gao@...soc.com>
> >>>
> >>> Now not only CPUs can use energy efficiency models, but GPUs
> >>> can also use. On the other hand, even with only one CPU, we can also
> >>> use energy_model to align control in thermal.
> >>> So remove the dependence of SMP, and add the DEVFREQ.
> >>
> >> That's true, there are 1-CPU platforms supported. Also, GPU can have
> >> the EM alone.
> >>
> >>>
> >>> Signed-off-by: Jeson Gao <jeson.gao@...soc.com>
> >>> ---
> >>>    kernel/power/Kconfig | 3 +--
> >>>    1 file changed, 1 insertion(+), 2 deletions(-)
> >>>
> >>> diff --git a/kernel/power/Kconfig b/kernel/power/Kconfig
> >>> index afce8130d8b9..c532aee09e12 100644
> >>> --- a/kernel/power/Kconfig
> >>> +++ b/kernel/power/Kconfig
> >>> @@ -361,8 +361,7 @@ config CPU_PM
> >>>
> >>>    config ENERGY_MODEL
> >>>        bool "Energy Model for devices with DVFS (CPUs, GPUs, etc)"
> >>> -     depends on SMP
> >>> -     depends on CPU_FREQ
> >>> +     depends on CPU_FREQ || PM_DEVFREQ
> >>>        help
> >>>          Several subsystems (thermal and/or the task scheduler for example)
> >>>          can leverage information about the energy consumed by devices to
> >>
> >> Reviewed-by: Lukasz Luba <lukasz.luba@....com>
>
> Gentle ping. You probably have missed that change for the v6.15 queue

Indeed, I have missed this one.

Now applied as 6.15 material, thanks!