linux-kernel - RE: [PATCH v3 1/3] dt-bindings: hwmon: Add Microchip emc2305 yaml schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID:
 <DU7PR04MB11163EE82B1F5228F797A0D64FFCB2@DU7PR04MB11163.eurprd04.prod.outlook.com>
Date: Wed, 5 Mar 2025 14:49:55 +0000
From: "Florin Leotescu (OSS)" <florin.leotescu@....nxp.com>
To: Daniel Baluta <daniel.baluta@...il.com>, Frank Li <frank.li@....com>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>
CC: "Florin Leotescu (OSS)" <florin.leotescu@....nxp.com>, Jean Delvare
	<jdelvare@...e.com>, Guenter Roeck <linux@...ck-us.net>, Rob Herring
	<robh@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Michael Shych
	<michaelsh@...dia.com>, "linux-hwmon@...r.kernel.org"
	<linux-hwmon@...r.kernel.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, Viorel Suman <viorel.suman@....com>, Carlos
 Song <carlos.song@....com>, "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "imx@...ts.linux.dev"
	<imx@...ts.linux.dev>, "festevam@...il.com" <festevam@...il.com>, Florin
 Leotescu <florin.leotescu@....com>
Subject: RE: [PATCH v3 1/3] dt-bindings: hwmon: Add Microchip emc2305 yaml
 schema

Hello Frank, Conor, Krzysztof,

Thanks a lot for your feedback, time and patience. 
We will address the changes in V4.

Regards,
Florin

-----Original Message-----
From: Daniel Baluta <daniel.baluta@...il.com> 
Sent: Wednesday, March 5, 2025 2:48 PM
To: Frank Li <frank.li@....com>; Krzysztof Kozlowski <krzk+dt@...nel.org>
Cc: Florin Leotescu (OSS) <florin.leotescu@....nxp.com>; Jean Delvare <jdelvare@...e.com>; Guenter Roeck <linux@...ck-us.net>; Rob Herring <robh@...nel.org>; Conor Dooley <conor+dt@...nel.org>; Michael Shych <michaelsh@...dia.com>; linux-hwmon@...r.kernel.org; devicetree@...r.kernel.org; linux-kernel@...r.kernel.org; Viorel Suman <viorel.suman@....com>; Carlos Song <carlos.song@....com>; linux-arm-kernel@...ts.infradead.org; imx@...ts.linux.dev; festevam@...il.com; Florin Leotescu <florin.leotescu@....com>
Subject: Re: [PATCH v3 1/3] dt-bindings: hwmon: Add Microchip emc2305 yaml schema

Hello Frank, Conor, Krzysztof,

Thanks a lot for your comments and help.

In this initial patchseries we only add minimal OF support and introduce a minimal binding.

> How did you pickup the maintainer entry?

We got the author of the first commit for See 0d8400c5a2ce ("hwmon: (emc2305) add support for EMC2301/2/3/5 RPM-based")

> If only one reg You can go through trivial-devices.yaml

This is not a trivial device as we will add some specific properties with our next patches (e.g polarity etc)

> Missing descriptions of the fans, no?
> missing $ref to fan-controller schema.

Do we need to add this now? As this is only the minimal binding support. We want to add that in a follow up patch when we go into specifics.

> The emc2301 label here can be dropped, it is not used.

Will fix.

> The nodename should be "fan-controller", not pwm here I guess.

Sure, will fix.

On Tue, Mar 4, 2025 at 6:56 PM Frank Li <Frank.li@....com> wrote:
>
> On Tue, Mar 04, 2025 at 06:21:34PM +0200, florin.leotescu@....nxp.com wrote:
> > From: Florin Leotescu <florin.leotescu@....com>
> >
> > Introduce yaml schema for Microchip emc2305 pwm fan controller.
> >
> > Signed-off-by: Florin Leotescu <florin.leotescu@....com>
> > ---
> >  .../bindings/hwmon/microchip,emc2305.yaml     | 43 +++++++++++++++++++
> >  1 file changed, 43 insertions(+)
> >  create mode 100644 
> > Documentation/devicetree/bindings/hwmon/microchip,emc2305.yaml
> >
> > diff --git 
> > a/Documentation/devicetree/bindings/hwmon/microchip,emc2305.yaml 
> > b/Documentation/devicetree/bindings/hwmon/microchip,emc2305.yaml
> > new file mode 100644
> > index 000000000000..cac0075a65bb
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/hwmon/microchip,emc2305.yaml
> > @@ -0,0 +1,43 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/hwmon/microchip,emc2305.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Microchip EMC2305 SMBus compliant PWM fan controller
> > +
> > +maintainers:
> > +  - Michael Shych <michaelsh@...dia.com>
>
> who is it? look like not Microchip and hwmon maintainer.
>
> > +
> > +description: |
>
> Needn't |
>
> > +  Microchip EMC2301/2/3/5 pwm controller which supports up  to five 
> > + programmable fan control circuits
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - microchip,emc2301
> > +      - microchip,emc2302
> > +      - microchip,emc2303
> > +      - microchip,emc2305
>
> According to your driver code look like all compatible with 
> microchip,emc2301
>
> oneOf:
>   - enum:
>       - microchip,emc2301
>   - items:
>       - enum:
>           - microchip,emc2302
>           - microchip,emc2303
>           - microchip,emc2305
>       - const: microchip,emc2301
>
> So your driver just need one "microchip,emc2301" compatible string.
>
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    i2c {
> > +        #address-cells = <1>;
> > +        #size-cells = <0>;
> > +
> > +        emc2301: pwm@2f {
> > +            compatible = "microchip,emc2301";
> > +            reg = <0x2f>;
>
> If only one reg:
> You can go through trivial-devices.yaml
>
> Frank
>
> > +        };
> > +    };
> > --
> > 2.34.1
> >
>