linux-kernel - [PATCH -next] drm: adp: Remove unnecessary print function dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250305020546.96564-1-jiapeng.chong@linux.alibaba.com>
Date: Wed,  5 Mar 2025 10:05:46 +0800
From: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
To: fnkl.kernel@...il.com
Cc: j@...nau.net,
	maarten.lankhorst@...ux.intel.com,
	mripard@...nel.org,
	tzimmermann@...e.de,
	airlied@...il.com,
	simona@...ll.ch,
	dri-devel@...ts.freedesktop.org,
	asahi@...ts.linux.dev,
	linux-kernel@...r.kernel.org,
	Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>,
	Abaci Robot <abaci@...ux.alibaba.com>
Subject: [PATCH -next] drm: adp: Remove unnecessary print function dev_err()

The print function dev_err() is redundant because platform_get_irq_byname()
already prints an error.

./drivers/gpu/drm/adp/adp_drv.c:470:2-9: line 470 is redundant because platform_get_irq() already prints an error.
./drivers/gpu/drm/adp/adp_drv.c:476:2-9: line 476 is redundant because platform_get_irq() already prints an error.

Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=19211
Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
---
 drivers/gpu/drm/adp/adp_drv.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/adp/adp_drv.c b/drivers/gpu/drm/adp/adp_drv.c
index 0a39abdc9238..0eeb9e5fab26 100644
--- a/drivers/gpu/drm/adp/adp_drv.c
+++ b/drivers/gpu/drm/adp/adp_drv.c
@@ -466,16 +466,12 @@ static int adp_parse_of(struct platform_device *pdev, struct adp_drv_private *ad
 	}
 
 	adp->be_irq = platform_get_irq_byname(pdev, "be");
-	if (adp->be_irq < 0) {
-		dev_err(dev, "failed to find be irq");
+	if (adp->be_irq < 0)
 		return adp->be_irq;
-	}
 
 	adp->fe_irq = platform_get_irq_byname(pdev, "fe");
-	if (adp->fe_irq < 0) {
-		dev_err(dev, "failed to find fe irq");
+	if (adp->fe_irq < 0)
 		return adp->fe_irq;
-	}
 
 	return 0;
 }
-- 
2.32.0.3.g01195cf9f