linux-kernel - Re: [PATCH 2/2] arm64: dts: rockchip: Add rk3528 QoS register node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52155b03-20f3-4e64-b636-70042db03ffa@kernel.org>
Date: Wed, 5 Mar 2025 16:41:23 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Chukun Pan <amadeus@....edu.cn>, Yao Zi <ziyao@...root.org>
Cc: Lee Jones <lee@...nel.org>, Rob Herring <robh@...nel.org>,
 Heiko Stuebner <heiko@...ech.de>, Conor Dooley <conor+dt@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>,
 linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org,
 linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: rockchip: Add rk3528 QoS register node

On 05/03/2025 15:00, Chukun Pan wrote:
> Copy QoS nodes and add rk3528 compatible from bsp kernel,

No, don't copy stuff from BSP kernel. It results in terrible DTS.

> these can be used for power-domain.
> 
> Signed-off-by: Chukun Pan <amadeus@....edu.cn>
> ---
>  arch/arm64/boot/dts/rockchip/rk3528.dtsi | 160 +++++++++++++++++++++++
>  1 file changed, 160 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3528.dtsi b/arch/arm64/boot/dts/rockchip/rk3528.dtsi
> index 5b334690356a..794f35654975 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3528.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3528.dtsi
> @@ -122,6 +122,166 @@ gic: interrupt-controller@...01000 {
>  			#interrupt-cells = <3>;
>  		};
>  
> +		qos_crypto_a: qos@...00000 {
> +			compatible = "rockchip,rk3528-qos", "syscon";
> +			reg = <0x0 0xff200000 0x0 0x20>;
> +		};
> +
> +		qos_crypto_p: qos@...00080 {
> +			compatible = "rockchip,rk3528-qos", "syscon";
> +			reg = <0x0 0xff200080 0x0 0x20>;
> +		};


Did you just define syscon per few registers? Third case last weeks...
so no, define what is your device here. 8 registers is not a device usually.

Best regards,
Krzysztof