linux-kernel - Re: [PATCH v3 1/3] iommu: Sort out domain user data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3699641b-c7bc-4fec-b8e2-828f5b1f2d70@arm.com>
Date: Wed, 5 Mar 2025 15:45:21 +0000
From: Robin Murphy <robin.murphy@....com>
To: kernel test robot <lkp@...el.com>, Nicolin Chen <nicolinc@...dia.com>,
 jgg@...dia.com, kevin.tian@...el.com, joro@...tes.org, will@...nel.org
Cc: oe-kbuild-all@...ts.linux.dev, iommu@...ts.linux.dev,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/3] iommu: Sort out domain user data

On 05/03/2025 3:18 pm, kernel test robot wrote:
> Hi Nicolin,
> 
> kernel test robot noticed the following build errors:
> 
> [auto build test ERROR on 5e9f822c9c683ae884fa5e71df41d1647b2876c6]
> 
> url:    https://github.com/intel-lab-lkp/linux/commits/Nicolin-Chen/iommu-Sort-out-domain-user-data/20250304-045529
> base:   5e9f822c9c683ae884fa5e71df41d1647b2876c6
> patch link:    https://lore.kernel.org/r/74a3bf91b52563faaf7ef7de065931e4df47e63f.1741034886.git.nicolinc%40nvidia.com
> patch subject: [PATCH v3 1/3] iommu: Sort out domain user data
> config: mips-randconfig-r071-20250305 (https://download.01.org/0day-ci/archive/20250305/202503052255.t1N6KrAn-lkp@intel.com/config)
> compiler: clang version 15.0.7 (https://github.com/llvm/llvm-project 8dfdcc7b7bf66834a761bd8de445840ef68e4d1a)
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250305/202503052255.t1N6KrAn-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@...el.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202503052255.t1N6KrAn-lkp@intel.com/
> 
> All errors (new ones prefixed by >>):
> 
>>> drivers/iommu/iommu.c:2039:10: error: label at end of compound statement: expected statement
>             default:
>                     ^
>                      ;
>     1 error generated.

Oops, my bad... omitting an extra break here was a semi-conscious 
brainfart. Weird that my AArch64 GCC doesn't complain about this 
construct though, even with "-ansi -Wall" - I have to go all the way to 
-Wpedantic before it notices :/

Thanks,
Robin.

> 
> 
> vim +2039 drivers/iommu/iommu.c
> 
>    2026	
>    2027	void iommu_domain_free(struct iommu_domain *domain)
>    2028	{
>    2029		switch (domain->cookie_type) {
>    2030		case IOMMU_COOKIE_DMA_IOVA:
>    2031			iommu_put_dma_cookie(domain);
>    2032			break;
>    2033		case IOMMU_COOKIE_DMA_MSI:
>    2034			iommu_put_msi_cookie(domain);
>    2035			break;
>    2036		case IOMMU_COOKIE_SVA:
>    2037			mmdrop(domain->mm);
>    2038			break;
>> 2039		default:
>    2040		}
>    2041		if (domain->ops->free)
>    2042			domain->ops->free(domain);
>    2043	}
>    2044	EXPORT_SYMBOL_GPL(iommu_domain_free);
>    2045	
>