linux-kernel - Re: [PATCH v8 4/4] scanf: break kunit into test cases

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z8hzrMS0GIip-WkT@smile.fi.intel.com>
Date: Wed, 5 Mar 2025 17:54:20 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Petr Mladek <pmladek@...e.com>
Cc: Tamir Duberstein <tamird@...il.com>, David Gow <davidgow@...gle.com>,
	Steven Rostedt <rostedt@...dmis.org>,
	Rasmus Villemoes <linux@...musvillemoes.dk>,
	Sergey Senozhatsky <senozhatsky@...omium.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Shuah Khan <shuah@...nel.org>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH v8 4/4] scanf: break kunit into test cases

On Wed, Mar 05, 2025 at 04:01:48PM +0100, Petr Mladek wrote:
> On Fri 2025-02-14 11:20:01, Tamir Duberstein wrote:

...

> >  #include <kunit/test.h>
> > -#include <linux/bitops.h>
> > -#include <linux/kernel.h>
> >  #include <linux/module.h>
> > -#include <linux/overflow.h>
> > -#include <linux/printk.h>
> >  #include <linux/prandom.h>
> >  #include <linux/slab.h>
> > -#include <linux/string.h>
> > +#include <linux/sprintf.h>
> >  
> >  #define BUF_SIZE 1024
> 
> It would make more sense to do this clean up in the 3rd patch
> where some code was replaced by the kunit macros.

+1.

> Also I am not sure about the choice. It might make sense to remove
> <include/printk.h> because the pr_*() calls were removed.
> But what about the others? Did anyone request the clean up, please?

Header inclusions is a pain point to me in the kernel. Esp. misuse of kernel.h
or other headers to behave like a "proxy". If no-one even asked for a cleanup
it's always good to follow IWYU principle as you mentioned below.

> I do not want to open a bike shadding because different people
> have different opinion.
> 
> I would personally prefer to keep the explicit includes when the
> related API is still used. It helps to optimize nested includes
> in the header files which helps to speedup build. AFAIK, there
> are people working in this optimization and they might need
> to revert this change.

+1.

-- 
With Best Regards,
Andy Shevchenko