linux-kernel - Re: [PATCH] PCI: pci_ids: Add Cixtech P1 Platforms vendor and device ID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250305174931.GA304679@bhelgaas>
Date: Wed, 5 Mar 2025 11:49:31 -0600
From: Bjorn Helgaas <helgaas@...nel.org>
To: hans.zhang@...tech.com
Cc: bhelgaas@...gle.com, cix-kernel-upstream@...tech.com,
	linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
	Peter Chen <peter.chen@...tech.com>
Subject: Re: [PATCH] PCI: pci_ids: Add Cixtech P1 Platforms vendor and device
 ID

On Wed, Mar 05, 2025 at 02:30:18PM +0800, hans.zhang@...tech.com wrote:
> From: Hans Zhang <hans.zhang@...tech.com>
> 
> Add Cixtech P1 (internal name sky1) as a vendor and device ID for PCI
> devices so we can use the macro for future drivers.

See note at top of file:

   *      Please keep sorted by numeric Vendor ID and Device ID.
   *
   *      Do not add new entries to this file unless the definitions
   *      are shared between multiple drivers.

Include this patch in a series that shows multiple drivers using it
and mention those drivers in the commit log.

Update the subject line to match the existing style (use "git log
--oneline include/linux/pci_ids.h"):

  PCI: Add Cix Technology Vendor and Device ID

> Signed-off-by: Hans Zhang <hans.zhang@...tech.com>
> Reviewed-by: Peter Chen <peter.chen@...tech.com>
> ---
>  include/linux/pci_ids.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
> index 1a2594a38199..531b34c1181a 100644
> --- a/include/linux/pci_ids.h
> +++ b/include/linux/pci_ids.h
> @@ -200,6 +200,9 @@
>  #define PCI_DEVICE_ID_COMPAQ_THUNDER	0xf130
>  #define PCI_DEVICE_ID_COMPAQ_NETFLEX3B	0xf150
>  
> +#define PCI_VENDOR_ID_CIX               0x1f6c
> +#define PCI_DEVICE_ID_CIX_SKY1          0x0001

This is not sorted by Vendor ID.

>  #define PCI_VENDOR_ID_NCR		0x1000
>  #define PCI_VENDOR_ID_LSI_LOGIC		0x1000
>  #define PCI_DEVICE_ID_NCR_53C810	0x0001
> 
> base-commit: 99fa936e8e4f117d62f229003c9799686f74cebc
> -- 
> 2.47.1
>