linux-kernel - Re: [PATCH 2/4] perf test: Skip perf probe tests when running as non-root

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z8iPQ-IVxIcAZIUU@google.com>
Date: Wed, 5 Mar 2025 09:52:03 -0800
From: Namhyung Kim <namhyung@...nel.org>
To: Arnaldo Carvalho de Melo <acme@...nel.org>
Cc: Ian Rogers <irogers@...gle.com>, Kan Liang <kan.liang@...ux.intel.com>,
	Jiri Olsa <jolsa@...nel.org>,
	Adrian Hunter <adrian.hunter@...el.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...nel.org>, LKML <linux-kernel@...r.kernel.org>,
	linux-perf-users@...r.kernel.org
Subject: Re: [PATCH 2/4] perf test: Skip perf probe tests when running as
 non-root

Hi Arnaldo,

On Wed, Mar 05, 2025 at 02:45:19PM -0300, Arnaldo Carvalho de Melo wrote:
> On Fri, Feb 28, 2025 at 08:02:50PM -0800, Namhyung Kim wrote:
> > perf trace requires root because it needs to use [ku]probes.
> > Skip those test when it's not run as root.
> > 
> > Before:
> >   $ perf test probe
> >    47: Probe SDT events                                                : Ok
> >   104: test perf probe of function from different CU                   : FAILED!
> >   115: perftool-testsuite_probe                                        : FAILED!
> >   117: Add vfs_getname probe to get syscall args filenames             : FAILED!
> >   118: probe libc's inet_pton & backtrace it with ping                 : FAILED!
> >   119: Use vfs_getname probe to get syscall args filenames             : FAILED!
> 
> Do you have ShellCheck installed?
> 
>   TEST    /tmp/build/perf-tools-next/tests/shell/probe_vfs_getname.sh.shellcheck_log
>   TEST    /tmp/build/perf-tools-next/tests/shell/record+probe_libc_inet_pton.sh.shellcheck_log
>   TEST    /tmp/build/perf-tools-next/tests/shell/record+script_probe_vfs_getname.sh.shellcheck_log
> 
> In tests/shell/probe_vfs_getname.sh line 11:
> [ "$(id -u)" == 0 ] || exit 2
>              ^-- SC3014 (warning): In POSIX sh, == in place of = is undefined.
> 
> For more information:
>   https://www.shellcheck.net/wiki/SC3014 -- In POSIX sh, == in place of = is ...

Sorry for the noise, it's fixed in v2.

Thanks,
Namhyung