linux-kernel - Re: [PATCH v2] arch/x86: Fix size overflows in sgx_encl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8255b211-5510-4c09-b13f-c4e3bd0d0aba@intel.com>
Date: Tue, 4 Mar 2025 16:18:03 -0800
From: Dave Hansen <dave.hansen@...el.com>
To: Jarkko Sakkinen <jarkko@...nel.org>, linux-integrity@...r.kernel.org,
 Dave Hansen <dave.hansen@...ux.intel.com>,
 Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>,
 Borislav Petkov <bp@...en8.de>, x86@...nel.org,
 "H. Peter Anvin" <hpa@...or.com>
Cc: Dan Carpenter <dan.carpenter@...aro.org>, linux-sgx@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] arch/x86: Fix size overflows in sgx_encl_create()

On 3/4/25 16:06, Jarkko Sakkinen wrote:
> +	/*
> +	 * This is a micro-architectural requirement. ECREATE would detect this
> +	 * too without mentionable overhead but this check guarantees also that
> +	 * the space calculations for EPC and shmem allocations never overflow.
> +	 */
> +	if (!is_power_of_2(secs->size))
> +		return -EINVAL;

Isn't it a plain old documented architectural requirement?