linux-kernel - Re: [PATCH] drm/amdgpu: handle amdgpu_cgs_create_device() errors in amd_powerplay

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADnq5_Nc62v7aB9xof1ZiTq0TQPJvxwjtvTO2KkaWwvfxEg03Q@mail.gmail.com>
Date: Wed, 5 Mar 2025 13:25:39 -0500
From: Alex Deucher <alexdeucher@...il.com>
To: Wentao Liang <vulab@...as.ac.cn>
Cc: kenneth.feng@....com, alexander.deucher@....com, christian.koenig@....com, 
	Xinhui.Pan@....com, airlied@...il.com, simona@...ll.ch, sunil.khatri@....com, 
	Jun.Ma2@....com, lijo.lazar@....com, amd-gfx@...ts.freedesktop.org, 
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/amdgpu: handle amdgpu_cgs_create_device() errors in amd_powerplay_create()

On Tue, Mar 4, 2025 at 4:29 AM Wentao Liang <vulab@...as.ac.cn> wrote:
>
> Add error handling to propagate amdgpu_cgs_create_device() failures
> to the caller. When amdgpu_cgs_create_device() fails, immediately
> return -EINVAL to stop further processing and prevent null pointer
> dereference.
>
> Signed-off-by: Wentao Liang <vulab@...as.ac.cn>
> ---
>  drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c b/drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c
> index 26624a716fc6..2cb05614466f 100644
> --- a/drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c
> +++ b/drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c
> @@ -51,6 +51,8 @@ static int amd_powerplay_create(struct amdgpu_device *adev)
>         hwmgr->adev = adev;
>         hwmgr->not_vf = !amdgpu_sriov_vf(adev);
>         hwmgr->device = amdgpu_cgs_create_device(adev);
> +       if (!hwmgr->device)
> +               return -EINVAL;

Please return -ENOMEM here.  Also, you need to free hwmgr as well in this case.

Alex

>         mutex_init(&hwmgr->msg_lock);
>         hwmgr->chip_family = adev->family;
>         hwmgr->chip_id = adev->asic_type;
> --
> 2.42.0.windows.2
>