linux-kernel - Re: [PATCH] include/linux/pipe_fs_i: Add htmldoc annotation for "head

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHk-=wivSEhRG3zJHd0WYz6rO9Gwzek6CMRMSmcHd2c6-01KuQ@mail.gmail.com>
Date: Wed, 5 Mar 2025 08:26:10 -1000
From: Linus Torvalds <torvalds@...ux-foundation.org>
To: K Prateek Nayak <kprateek.nayak@....com>
Cc: Oleg Nesterov <oleg@...hat.com>, Stephen Rothwell <sfr@...b.auug.org.au>, linux-kernel@...r.kernel.org, 
	Linux Next Mailing List <linux-next@...r.kernel.org>, Swapnil Sapkal <swapnil.sapkal@....com>
Subject: Re: [PATCH] include/linux/pipe_fs_i: Add htmldoc annotation for
 "head_tail" member

On Wed, 5 Mar 2025 at 08:08, K Prateek Nayak <kprateek.nayak@....com> wrote:
>
> > And it turns out my worry about pipe_discard_from() was unnecessary.
> > Yes, the code is buggy. But no, it doesn't matter. Why? There are no
> > callers of that function ;)
>
]> I don't see any in kernel user of this helper currently so can the
> wrap-around issue be addressed and the helper be removed later?

Yes. That's what I did. I still would love to see

 - more testing

 - explicit limit checking in pipe_resize_ring()

and then I think we could make CONFIG_64BIT use the 16-bit
pipe_index_t too (because not doing so clearly was a mistake: it meant
that people didn't test the 32-bit case, so the wrap-around bugs
weren't as obvious).

                 Linus

                    Linus