linux-kernel - Re: [PATCH RESEND] tipc: Reduce scope for the variable “fdefq” in tipc_link_tnl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250304185048.3db84306@kernel.org>
Date: Tue, 4 Mar 2025 18:50:48 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Markus Elfring <Markus.Elfring@....de>
Cc: kernel-janitors@...r.kernel.org, tipc-discussion@...ts.sourceforge.net,
 netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Jon Maloy <jmaloy@...hat.com>, Paolo Abeni
 <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, Tuong Lien
 <tuong.t.lien@...tech.com.au>, Ying Xue <ying.xue@...driver.com>,
 cocci@...ia.fr, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH RESEND] tipc: Reduce scope for the variable
 “fdefq” in tipc_link_tnl_prepare()

On Sun, 2 Mar 2025 21:30:27 +0100 Markus Elfring wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Thu, 13 Apr 2023 17:00:11 +0200
> 
> The address of a data structure member was determined before
> a corresponding null pointer check in the implementation of
> the function “tipc_link_tnl_prepare”.
> 
> Thus avoid the risk for undefined behaviour by moving the definition
> for the local variable “fdefq” into an if branch at the end.
> 
> This issue was detected by using the Coccinelle software.
> 
> Fixes: 58ee86b8c775 ("tipc: adapt link failover for new Gap-ACK algorithm")
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>

Applied without the Fixes tag, thanks.