linux-kernel - Re: [PATCH v6 3/3] tty: Change order of ttynull to be linked sooner if enabled as a console.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VfadXS8Z2G6U_DcOOZFFmaOSn_9uQN_N7Psse3kiSGj0g@mail.gmail.com>
Date: Wed, 5 Mar 2025 20:52:00 +0200
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Adam Simonelli <adamsimonelli@...il.com>
Cc: linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Jiri Slaby <jirislaby@...nel.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
	Steven Rostedt <rostedt@...dmis.org>, John Ogness <john.ogness@...utronix.de>, 
	Sergey Senozhatsky <senozhatsky@...omium.org>, Petr Mladek <pmladek@...e.com>
Subject: Re: [PATCH v6 3/3] tty: Change order of ttynull to be linked sooner
 if enabled as a console.

On Wed, Mar 5, 2025 at 4:06 AM Adam Simonelli <adamsimonelli@...il.com> wrote:
> On Tuesday, March 4, 2025 1:51:52 AM EST Andy Shevchenko wrote:
> > On Tue, Mar 4, 2025 at 5:55 AM <adamsimonelli@...il.com> wrote:

...

> > >  obj-y                          += vt/
> >
> > + blank line.
> >
> > > +# If ttynull is configured to be a console by default, ensure that it is linked
> > > +# earlier before a real one is selected.
> > > +obj-$(CONFIG_NULL_TTY_DEFAULT_CONSOLE) \
> > > +                               += ttynull.o
> >
> > Here is the question: are you sure that all console drivers that exist
> > in the kernel happen to be here? Have you grepped the source tree for
> > checking this?
> >
> Grepping for console_initcall, the only other places I see outside of
> drivers/tty/ is
>
> arch/mips/fw/arc/arc_con.c
> arch/mips/sibyte/common/cfe_console.c
> arch/powerpc/kernel/legacy_serial.c
> arch/powerpc/kernel/udbg.c
> arch/powerpc/platforms/powermac/setup.c
> arch/um/drivers/stderr_console.c
> arch/xtensa/platforms/iss/console.c
> drivers/s390/char/con3215.c
> drivers/s390/char/con3270.c
> drivers/s390/char/sclp_con.c
> drivers/s390/char/sclp_vt220.c

Which means you need to test your stuff on those cases, to see how the
linker order is done there. It might be that your change wouldn't work
there as expected (quick workaround is to mark the new option as
depends on !S390 && !PPC and so on.

-- 
With Best Regards,
Andy Shevchenko