linux-kernel - Re: [PATCH v2 1/2] clk: samsung: Use samsung CCF common function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6cbd3df3-344f-4c4f-886d-f0bb99b824da@kernel.org>
Date: Wed, 5 Mar 2025 20:15:28 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Varada Pavani <v.pavani@...sung.com>, aswani.reddy@...sung.com,
 pankaj.dubey@...sung.com, s.nawrocki@...sung.com, cw00.choi@...sung.com,
 alim.akhtar@...sung.com, mturquette@...libre.com, sboyd@...nel.org,
 linux-samsung-soc@...r.kernel.org, linux-clk@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Cc: gost.dev@...sung.com
Subject: Re: [PATCH v2 1/2] clk: samsung: Use samsung CCF common function

On 25/02/2025 14:19, Varada Pavani wrote:
> Use samsung CCF function which registers multiple clock providers using
> single function call samsung_cmu_register_clocks().
> 
> Signed-off-by: Varada Pavani <v.pavani@...sung.com>
> ---
>  drivers/clk/samsung/clk-exynos4.c | 78 +++++++++++++++++--------------
>  1 file changed, 44 insertions(+), 34 deletions(-)

Please run scripts/checkpatch.pl and fix reported warnings. After that,
run also `scripts/checkpatch.pl --strict` and (probably) fix more
warnings. Some warnings can be ignored, especially from --strict run,
but the code here looks like it needs a fix. Feel free to get in touch
if the warning is not clear.

Best regards,
Krzysztof