linux-kernel - Re: [PATCH v2] mm/shrinker: fix name consistency issue in shrinker_debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z8ij1cHYljL_xQwg@google.com>
Date: Wed, 5 Mar 2025 19:19:49 +0000
From: Roman Gushchin <roman.gushchin@...ux.dev>
To: Liu Ye <liuye@...inos.cn>
Cc: akpm@...ux-foundation.org, david@...morbit.com,
	zhengqi.arch@...edance.com, muchun.song@...ux.dev,
	linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] mm/shrinker: fix name consistency issue in
 shrinker_debugfs_rename()

On Wed, Mar 05, 2025 at 03:17:59PM +0800, Liu Ye wrote:
> After calling debugfs_change_name function, the return value should be
> checked and the old name restored. If debugfs_change_name fails, the new
> name memory should be freed. The effect is that the shrinker->name is not
> consistent with the name displayed in debugfs.
> 
> Signed-off-by: Liu Ye <liuye@...inos.cn>
> Reviewed-by: Muchun Song <muchun.song@...ux.dev>
> Reviewed-by：Qi Zheng <zhengqi.arch@...edance.com>

Reviewed-by: Roman Gushchin <roman.gushchin@...ux.dev>

Thanks!