linux-kernel - Re: [PATCH] EDAC: fix dev_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250305225141.GCZ8jVfTBDi0x0XhTW@fat_crate.local>
Date: Wed, 5 Mar 2025 23:51:41 +0100
From: Borislav Petkov <bp@...en8.de>
To: Arnd Bergmann <arnd@...nel.org>
Cc: Tony Luck <tony.luck@...el.com>, Fan Ni <fan.ni@...sung.com>,
	Jonathan Cameron <Jonathan.Cameron@...wei.com>,
	Shiju Jose <shiju.jose@...wei.com>, Arnd Bergmann <arnd@...db.de>,
	James Morse <james.morse@....com>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	Robert Richter <rric@...nel.org>,
	"Jiri Slaby (SUSE)" <jirislaby@...nel.org>,
	linux-edac@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] EDAC: fix dev_set_name() format string

On Tue, Mar 04, 2025 at 03:35:58PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> Passing a variable string as the format to dev_set_name() causes a W=1 warning:
> 
> drivers/edac/edac_device.c:736:9: error: format not a string literal and no format arguments [-Werror=format-security]
>   736 |         ret = dev_set_name(&ctx->dev, name);
>       |         ^~~
> 
> Use a literal "%s" instead so the name can be the argument.
> 
> Fixes: db99ea5f2c03 ("EDAC: Add support for EDAC device features control")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/edac/edac_device.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette